Skip to content

enhance: reduce group-by map allocation churn - #53220

Open
lyang24 wants to merge 1 commit into
milvus-io:masterfrom
lyang24:enhance/group-by-map-capacity-probe
Open

enhance: reduce group-by map allocation churn#53220
lyang24 wants to merge 1 commit into
milvus-io:masterfrom
lyang24:enhance/group-by-map-capacity-probe

Conversation

@lyang24

@lyang24 lyang24 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

issue: #53218

Signed-off-by: lyang24 <lanqingy93@gmail.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Sep 6, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign foxspy after the PR has been reviewed.
You can assign the PR to them by writing /assign @foxspy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify Bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 6, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-code-check-macos // for Code Checker MacOS (GitHub Actions)
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
  • /ci-rerun-buildenv // for ci-v2/build-env (build milvus-env builder images; update .env after the new tag is ready)
  • /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
  • /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
  • /ci-rerun-e2e-default // for ci-v2/e2e-default
  • /ci-rerun-e2e-amd // for ci-v2/e2e-amd (e2e pool dispatcher)
  • /ci-rerun-e2e-dist-wp // for ci-v2/e2e-dist-wp (Tencent distributed woodpecker-service boundary)
  • /ci-rerun-build-ut-cov // for ci-v2/build-ut-cov (build + unit tests in one pipeline)
  • /ci-rerun-build-ut-cov-tcus // force TC-US shadow
  • /ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests, ARM)
  • /ci-rerun-gosdk-std // for ci-v2/go-sdk-std (Go SDK E2E, standalone)
  • /ci-rerun-gosdk-dist-wp // for ci-v2/go-sdk-dist-wp (Go SDK E2E, distributed + Woodpecker service)

If you have any questions or requests, please contact @zhikunyao.

@sre-ci-robot

Copy link
Copy Markdown
Contributor

✅ CI Loop Results be49e91

Stage Result Duration Tests
✅ Build SUCCESS 17.2min -
✅ Code-Check SUCCESS 7.8min -
✅ UT-Integration SUCCESS 28.9min -
✅ UT-GO SUCCESS 25.9min -
✅ UT-CPP-Cov SUCCESS 66.5min 8819 total, 8819 passed, 0 failed

Total: 91min | Pipeline | Artifacts

Overall Coverage: 75.1%
Diff Coverage: CPP 100.0% (7 hit, 0 miss, 7 measurable lines, 54 unmeasured)
Diff Coverage HTML: view changed lines
Total Patch Coverage: 100.0% (7/7 measurable lines, 54 unmeasured)

@mergify mergify Bot added the ci-passed label Sep 7, 2026
//note it may enumerate all data inside a segment and can block following
//query and search possibly
std::vector<GroupedResult> res;
res.reserve(static_cast<size_t>(search_info.topk_) *

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal/core/src/exec/operator/search-groupby/SearchGroupByOperator.cpp line:211
Low ---- The repository's CODE_REVIEW.md asks that performance PRs list benchmark results; this change reworks the group-by hot path (Push capacity probe + result-vector reserve) but the PR description contains no benchmark data, so the claimed allocation-churn reduction is not yet verifiable. Consider adding a before/after measurement. Non-blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants