enhance: reduce group-by map allocation churn - #53220
Conversation
Signed-off-by: lyang24 <lanqingy93@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
✅ CI Loop Results
|
| Stage | Result | Duration | Tests |
|---|---|---|---|
| ✅ Build | SUCCESS | 17.2min | - |
| ✅ Code-Check | SUCCESS | 7.8min | - |
| ✅ UT-Integration | SUCCESS | 28.9min | - |
| ✅ UT-GO | SUCCESS | 25.9min | - |
| ✅ UT-CPP-Cov | SUCCESS | 66.5min | 8819 total, 8819 passed, 0 failed |
Total: 91min | Pipeline | Artifacts
Overall Coverage: 75.1%
Diff Coverage: CPP 100.0% (7 hit, 0 miss, 7 measurable lines, 54 unmeasured)
Diff Coverage HTML: view changed lines
Total Patch Coverage: 100.0% (7/7 measurable lines, 54 unmeasured)
| //note it may enumerate all data inside a segment and can block following | ||
| //query and search possibly | ||
| std::vector<GroupedResult> res; | ||
| res.reserve(static_cast<size_t>(search_info.topk_) * |
There was a problem hiding this comment.
internal/core/src/exec/operator/search-groupby/SearchGroupByOperator.cpp line:211
Low ---- The repository's CODE_REVIEW.md asks that performance PRs list benchmark results; this change reworks the group-by hot path (Push capacity probe + result-vector reserve) but the PR description contains no benchmark data, so the claimed allocation-churn reduction is not yet verifiable. Consider adding a before/after measurement. Non-blocking.
issue: #53218