Add localized MD/HTML file for guidance when incompatible VSIX - #8920
Merged
Colen Garoutte-Carson (Colengms) merged 11 commits intoFeb 28, 2022
Conversation
…nto coleng/detect_wrong_vsix
…nto coleng/detect_wrong_vsix
Sean McManus (sean-mcmanus)
requested changes
Feb 24, 2022
Contributor
|
Colen Garoutte-Carson (@Colengms) Was the vsix supposed to be built with this? |
Member
No, this is for 1.9.2 |
Sean McManus (sean-mcmanus)
requested changes
Feb 28, 2022
Sean McManus (sean-mcmanus)
left a comment
Sean McManus (sean-mcmanus)
left a comment
Contributor
There was a problem hiding this comment.
occuring ->occurring
Sean McManus (sean-mcmanus)
approved these changes
Feb 28, 2022
Colen Garoutte-Carson (Colengms)
deleted the
coleng/detect_wrong_vsix
branch
February 28, 2022 23:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add localized MD/HTML file for guidance when incompatible/mismatching VSIX is detected. This MD file is actually HTML, to enable localization.
Fixes an issue in which a redundant English version of each localized HTML file was included in the VSIX.
Adds a persistent var to suppress the warning when mismatched but compatible VSIX is detected.
I'm open to discussion on what to use as error/warning text and MD/HTML document contents.