Add C++ configuration as a language model tool (luca) - #12685
Merged
Colen Garoutte-Carson (Colengms) merged 11 commits intoSep 6, 2024
Merged
Add C++ configuration as a language model tool (luca)#12685Colen Garoutte-Carson (Colengms) merged 11 commits into
Colen Garoutte-Carson (Colengms) merged 11 commits into
Conversation
Luca (lukka)
changed the title
format lmTools.ts
Colen Garoutte-Carson (Colengms)
requested changes
Sep 5, 2024
Luca (lukka)
marked this pull request as ready for review
September 5, 2024 18:45
Sean McManus (sean-mcmanus)
previously approved these changes
Sep 5, 2024
Colen Garoutte-Carson (Colengms)
previously approved these changes
Sep 5, 2024
- dispose the token callback. - get rid of magic numbers with consts.
Luca (lukka)
dismissed stale reviews from Colen Garoutte-Carson (Colengms) and Sean McManus (sean-mcmanus)
via
September 5, 2024 23:04
7105e65
Colen Garoutte-Carson (Colengms)
previously approved these changes
Sep 6, 2024
Luca (lukka)
commented
Sep 6, 2024
Luca (lukka)
requested review from
Colen Garoutte-Carson (Colengms),
Ben McMorran (benmcmorran) and
Sean McManus (sean-mcmanus)
September 6, 2024 20:46
Sean McManus (sean-mcmanus)
requested changes
Sep 6, 2024
Sean McManus (sean-mcmanus)
previously approved these changes
Sep 6, 2024
Sean McManus (sean-mcmanus)
approved these changes
Sep 6, 2024
Colen Garoutte-Carson (Colengms)
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing feedback from PR #12577