Inactive regions don't dim in non-root folders

[Prehistoricman]

Type: LanguageService

Describe the bug

• OS and Version: Windows 10 Pro
• VS Code Version: 1.47.2
• C/C++ Extension Version: 0.29.0
• Other extensions you installed (and if the issue persists after disabling them): CMake, Python, SVN, Verilog-HDL/SystemVerilog
• Does this issue involve using SSH remote to run the extension on a remote machine?: No

I have a workspace with two folders: the project itself (root folder) and the SDK I'm using. Inactive regions look just fine in the root folder's files but they don't function in the SDK's files. I made a minimal reproduction example:

You can see above that main.c has the dimmed text in the correct place.

However, the SDK file doesn't have any dimmed text. It really does believe it's dimmed, as you can see by the hint I'm given.

Steps to reproduce

1. Open folder with a C file inside
2. Open another folder in the same workspace also with a C file inside
3. Observe that inactive regions are not dimmed in the other folder, only the root folder
   This is the text I used in both of my C files:

#define HELLO 1

void lib() {
#if HELLO
    hello_world2;
#else
    hello_world1;
#endif
}

Expected behavior

Inactive region dimming should be active for both files.

Logs

-------- Diagnostics - 23/07/2020, 19:25:09
Version: 0.29.0
Current Configuration:
{
    "name": "Win32",
    "includePath": [
        "${workspaceFolder}/**"
    ],
    "defines": [
        "_DEBUG",
        "UNICODE",
        "_UNICODE"
    ],
    "windowsSdkVersion": "10.0.18362.0",
    "cStandard": "c11",
    "cppStandard": "c++17",
    "intelliSenseMode": "msvc-x64",
    "compilerPath": "C:/Program Files (x86)/GNU Tools ARM Embedded/8 2018-q4-major/bin/arm-none-eabi-gcc.exe",
    "compilerArgs": [],
    "browse": {
        "path": [
            "${workspaceFolder}/**"
        ],
        "limitSymbolsToIncludedHeaders": true
    }
}
Translation Unit Mappings:
[ D:\Temporary\inactiveregions\copy\lib\sdk.c ]:
    D:\TEMPORARY\INACTIVEREGIONS\COPY\LIB\SDK.C
Translation Unit Configurations:
[ D:\Temporary\inactiveregions\copy\lib\sdk.c ]:
    Process ID: 17772
    Memory Usage: 11 MB
    Compiler Path: C:/Program Files (x86)/GNU Tools ARM Embedded/8 2018-q4-major/bin/arm-none-eabi-gcc.exe
    Includes:
        C:\PROGRAM FILES (X86)\GNU TOOLS ARM EMBEDDED\8 2018-Q4-MAJOR\LIB\GCC\ARM-NONE-EABI\8.2.1\INCLUDE
        C:\PROGRAM FILES (X86)\GNU TOOLS ARM EMBEDDED\8 2018-Q4-MAJOR\LIB\GCC\ARM-NONE-EABI\8.2.1\INCLUDE-FIXED
        C:\PROGRAM FILES (X86)\GNU TOOLS ARM EMBEDDED\8 2018-Q4-MAJOR\ARM-NONE-EABI\INCLUDE
    Defines:
        _DEBUG
        UNICODE
        _UNICODE
    Standard Version: c11
    IntelliSense Mode: gcc-x64
    Other Flags:
        --gcc
        --gnu_version=80201
Total Memory Usage: 11 MB

Additional context
I also notice that using a macro comment (like #if 0) causes both files to display green comment text for the disabled area, but only the file in the root folder is dimmed.

[Prehistoricman]

May be related to #5812? I don't have custom colours set up however.

[sean-mcmanus]

Yeah, it's related to #5812 and will be fixed in our next release.

[sean-mcmanus]

This was supposed to be fixed with https://github.com/microsoft/vscode-cpptools/releases/tag/0.30.0-insiders, but I'm still seeing the bug repro, so there might still be more work to do.

[sean-mcmanus]

Are you seeing this issue fixed with 0.30.0-insiders?

I'm seeing this being fixed now -- I don't know why I was not seeing the fix yesterday (with the same project and settings). Maybe there's some particular scenario that still has an issue, but I don't know the repro requirements yet.

[Prehistoricman]

Are you seeing this issue fixed with 0.30.0-insiders?

Yes, both in my real code and the minimal example I made.

[Colengms]

Prehistoricman . I'm not able to repro this issue with 0.30.0-insiders, with just a simple multi-root workspace. Perhaps your issue is actually due to a failed IntelliSense parse in one of your folders? Failure to complete an IntelliSense parse would result in no inactive region dimming, no squiggles (from the C/C++ Extension), and no semantic colorization.

Could you enable debug logging using "C_Cpp.loggingLevel": "Debug", and provide the content of your C/C++ output channel, starting from a fresh launch, and up until the output has settled after repro'ing the issue?

Also, could you provide the output of the C/C++: Log Diagnostics command, with both the working and non-working files open?

[Prehistoricman]

No, I'm telling you it's fixed in 0.30.0-insiders.

Edit:
Additionally, it's a purely graphical issue. As you can see in the screenshots above, the code that is not dimmed still has the hint to disable inactive region colorization. I think I would realise if intelliSense wasn't operating...