drcs: reject attempts to write a glyph that is too tall - #20409
Merged
Conversation
Member
Author
|
/cc James Holderness (@j4james) I think this is safe enough for existing DRCS fonts. (This is similar to the Sixel OOB write, triggered by a DRCS payload with a couple hundred million |
Dustin L. Howett (DHowett)
added this to
1.25 Servicing Pipeline and 1.24 Servicing Pipeline
PankajBhojwani
approved these changes
Jul 10, 2026
Dustin L. Howett (DHowett)
enabled auto-merge (squash)
July 10, 2026 21:32
Dustin L. Howett (DHowett)
moved this from To Cherry Pick
to Cherry Picked
in 1.24 Servicing Pipeline
Dustin L. Howett (DHowett)
moved this from To Cherry Pick
to Cherry Picked
in 1.25 Servicing Pipeline
Dustin L. Howett (DHowett)
added a commit
that referenced
this pull request
Jul 10, 2026
We probably shouldn't walk this iterator off the end of the array. Or write into it. (cherry picked from commit dd494ac) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgycxr4 Service-Version: 1.24
Dustin L. Howett (DHowett)
added a commit
that referenced
this pull request
Jul 10, 2026
We probably shouldn't walk this iterator off the end of the array. Or write into it. (cherry picked from commit dd494ac) Service-Card-Id: PVTI_lADOAF3p4s4BQX0-zgycxrs Service-Version: 1.25
Collaborator
|
Sorry about the bug. I think the fix is probably fine. You do get fonts that'll have some rows that are out of range, and ideally we should just be ignoring that rather than aborting the whole font, but if we're only going to hit the limit at MAX_HEIGHT, it's unlikely to be an issue in practice. |
Member
Author
|
np, thank you for looking! |
James Edmond Smith (jamesedmondsmith7-coder)
left a comment
James Edmond Smith (jamesedmondsmith7-coder)
left a comment
There was a problem hiding this comment.
Seems like the o
Pixel is moving to many times after the entry try one + not ++.
Dustin L. Howett (DHowett)
moved this from Cherry Picked
to Shipped
in 1.25 Servicing Pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We probably shouldn't walk this iterator off the end of the array. Or write into it.