Skip to content

Enclose the app path in quotes, so that the open command doesn't split it if it contains spaces #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eloy Durán (alloy) merged 2 commits into from
Dec 28, 2020
Merged

Enclose the app path in quotes, so that the open command doesn't split it if it contains spaces #678

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96c1975
Enclose the app path in quotes, so that the `open` command doesn't sp…
sergi Dec 17, 2020
d3c119f
[ado] Remove no longer needed homebrew fix
alloy Dec 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion local-cli/runMacOS/runMacOS.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ async function run(xcodeProject, scheme, args) {
);

child_process.exec(
'open -b ' + bundleID + ' -a ' + appPath,
'open -b ' + bundleID + ' -a ' + '"' + appPath + '"',
(error, stdout, stderr) => {
if (error) {
logger.error('Failed to launch the app', stderr);
Expand Down