Port FX ResultSet tests to state-machine based JUnit5 tests (legacyFx) - #2912
Merged
Conversation
Ananya Garg (Ananya2)
requested review from
Divang Sharma (divang),
Mahendra Chavan (machavan) and
Muskan Gupta (muskan124947)
March 11, 2026 10:08
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2912 +/- ##
============================================
+ Coverage 60.61% 60.64% +0.02%
- Complexity 4911 4915 +4
============================================
Files 151 151
Lines 35000 35000
Branches 5854 5854
============================================
+ Hits 21216 21224 +8
+ Misses 10939 10934 -5
+ Partials 2845 2842 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Ports legacy FX ResultSet functional scenarios into the JUnit 5 state-machine testing framework under the legacyFx tag, expanding the modeled ResultSet state and action space to cover more navigation, row operations, update flows, and close semantics.
Changes:
- Rewrites
ResultSetStateTestinto a nested JUnit 5 structure with model runs plus many scenario-focused tests (scan/movers/rowers/updaters/findColumn/fetch/close). - Expands
ResultSetStateto track additional ResultSet metadata and flags (insert-row, deleted-row, updatability, scrollability, etc.). - Extends
ResultSetActionswith additional modeled actions (relative navigation, insert-row toggles, updates, deletes, refresh, positional checks).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/test/java/com/microsoft/sqlserver/jdbc/statemachinetest/resultset/ResultSetStateTest.java |
Large JUnit 5 rewrite adding nested scenario tests and state-machine model runs for ResultSet behaviors. |
src/test/java/com/microsoft/sqlserver/jdbc/statemachinetest/resultset/ResultSetState.java |
Adds new state keys to support richer ResultSet modeling (insert-row, deleted-row, updatability/scrollability, etc.). |
src/test/java/com/microsoft/sqlserver/jdbc/statemachinetest/resultset/ResultSetActions.java |
Adds/updates state-machine actions to exercise additional ResultSet operations and update workflows. |
Ananya Garg (Ananya2)
force-pushed
the
user/anagarg/resultset-fx-test
branch
from
March 19, 2026 10:23
a7b3dcf to
6a22a49
Compare
…icrosoft/mssql-jdbc into user/anagarg/resultset-fx-test
…icrosoft/mssql-jdbc into user/anagarg/resultset-fx-test
…icrosoft/mssql-jdbc into user/anagarg/resultset-fx-test
Mahendra Chavan (machavan)
approved these changes
Mar 25, 2026
Muskan Gupta (muskan124947)
approved these changes
Mar 25, 2026
Divang Sharma (divang)
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports FX ResultSet functional scenarios to the JUnit 5 state-machine testing framework under the legacyFx tag. The migration replaces legacy FX tests with structured model-based tests that systematically explore ResultSet state transitions and behaviors, improving maintainability and coverage.
The update expands ResultSetState with additional state keys to track insert-row state, row deletion status, updatability, scrollability, connection and statement references, row counts, and table metadata. It also introduces new action classes in ResultSetActions to model ResultSet navigation, row operations, update workflows, and positional checks. ResultSetStateTest has been rewritten using nested test structures to organize scenarios covering model exploration, scanning behavior, movers, row operations, updates, getters, updaters, fetch configuration, findColumn, cascading close behavior, and edge cases.