Backport : Revert "Use sys.all_objects for accurate function and procedure filtering - #2759
Closed
Muskan Gupta (muskan124947) wants to merge 1 commit into
Closed
Backport : Revert "Use sys.all_objects for accurate function and procedure filtering#2759Muskan Gupta (muskan124947) wants to merge 1 commit into
Muskan Gupta (muskan124947) wants to merge 1 commit into
Conversation
Muskan Gupta (muskan124947)
requested review from
Ananya Garg (Ananya2),
Divang Sharma (divang) and
Mahendra Chavan (machavan)
September 9, 2025 05:40
Ananya Garg (Ananya2)
previously approved these changes
Sep 9, 2025
Muskan Gupta (muskan124947)
changed the base branch from
main
to
release/13.2
September 9, 2025 05:49
Muskan Gupta (muskan124947)
dismissed
Ananya Garg (Ananya2)’s stale review
September 9, 2025 05:49
The base branch was changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backported PR: #2751
This reverts commit 27a0bcd.
This change is being reverted due to differences in behavior observed between:
Specifically:
getProcedures() and getFunctions() return procedure/function names without numbered suffixes, since sys.all_objects does not expose numbered procedures.
In contrast, getProcedureColumns() and getFunctionColumns() query sp_sproc_columns, which does return numbered procedures, leading to inconsistencies across these APIs.
There was an effort done to make getProcedureColumns() and getFunctionColumns() work in #2743.
This PR addressed these differences, but SQL Server still supports numbered procedures, and users can benefit from grouped procedures (see here : sp_proc_columns)
To maintain compatibility and avoid unexpected discrepancies, this PR reverts #2705 and restores the original behavior.