This repository was archived by the owner on Jun 5, 2025. It is now read-only.
[FE+version control] Surface feature in Stable and update DevHome.Helpers to 1.0.20240910-x0103 - #3825
Merged
Merged
Conversation
ssparach
approved these changes
Sep 10, 2024
Member
Author
I'm probably fine with it, but maybe consider waiting until we're ready to set it to enabled by default? I know there's some finishing touches we're still working on, and even though it's enable-able in Stable, it's still off by default and won't even be visible unless the OS features are active. What's Dev Home's typical bar to meet for this sort of thing? |
Collaborator
We've been deciding on a case-by-case basis. Happy to wait for until it's enabled by default, I'll move it out a couple milestones and put a note in the issue that it is available to be turned on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description of the pull request / Additional comments
This removes some older workaround code that was used for internal validation in the helpers package. There are some older internal Windows builds we'll start excluding by reporting the feature as not present. But I think we're fine at this point. This will also allow us to be more selective about which public, external Windows builds we'll report the feature present on.
Between this cleanup, using the featurePresenceCheck, and the increasingly stable state of the FE+git integration, I believe we're ready to make this feature visible but disabled by default in the stable build. This will make it even easier for internal selfhosters to try out the feature and for Windows Beta seekers to try it out as we start rolling out the Windows infrastructure publicly.
Validation steps performed
Ran the registration/unregistration flows with the new package and validated that everything still works as expected, just to rule out any silly mistakes.