[Medium] Patch nodejs for CVE-2025-23167#14333
Conversation
6b9cdb8 to
7b6f04b
Compare
f2820a6 to
a9cda3b
Compare
There was a problem hiding this comment.
Given the number of changes in patch, we should proceed with nodejs 20.19.2 upgrade. From the response of copilot, 20.19.2 version should be compatible with 20.14
"""
Yes, Node.js 20.19.x is backward compatible with 20.14.x because both are part of the same LTS major version (20.x). Node.js follows semantic versioning, so:
Minor releases (20.14 → 20.19) only add features, improvements, and security fixes.
They do not introduce breaking changes to existing APIs within the same major version.
Your existing code that runs on 20.14 should work on 20.19 without modification.
The only differences you might notice:
Security patches (like CVE-2025-23167 fix).
Performance improvements and bug fixes.
Occasionally, new warnings for deprecated features (but no removals).
✅ Safe to upgrade: For your case, moving from 20.14.0 → 20.19.2 is considered a drop-in replacement.
"""
Given that we are going to support nodejs for Azure Linux 3.0 for longer durations, the patching will become difficult over time and also nodejs 20.14 is part of same LTS as 20.19 and nodejs 20.x series is maintained series from upstream community. This version upgrade will give us flexibility for future vulnerability fixes with further maintained/stable version of nodejs from package maintainer themselves.
|
@Sumynwa, gentle reminder for review and approval! |
1 similar comment
|
@Sumynwa, gentle reminder for review and approval! |
bd637f1 to
5665ac0
Compare
mfrw
left a comment
There was a problem hiding this comment.
Agree with @kgodara912
I think we should refrain from taking a 15k line patch, and do a minor upgrade instead.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
patch nodejs for CVE-2025-23167
Astrolabe Patch Reference: nodejs/node#48981
Upstream patch reference: nodejs/node@a7b8e85
Patch Modified: Yes
doc/contributing/maintaining/maintaining-dependencies.mdas no version information is given in code for other deps also.Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology