Skip to content

Remove retired GitHub Models integration - #19848

Open
Eric Erhardt (eerhardt) wants to merge 2 commits into
mainfrom
eerhardt-remove-github-model-resources
Open

Remove retired GitHub Models integration#19848
Eric Erhardt (eerhardt) wants to merge 2 commits into
mainfrom
eerhardt-remove-github-model-resources

Conversation

@eerhardt

Copy link
Copy Markdown
Member

Description

GitHub Models was fully retired on July 30, 2026, so the Aspire.Hosting.GitHub.Models integration no longer works. Aspire 13.5 shipped the final obsolete package; this change now removes the integration from the repository.

The source project, API baselines, tests, polyglot fixtures, and end-to-end playground are removed along with their solution entries. The current connection-properties specification no longer lists GitHubModel.

The package remains in the CLI deprecated-package blocklist so previously published versions stay hidden from aspire add. Historical release notes are also preserved.

Breaking changes

Aspire.Hosting.GitHub.Models and its public APIs are no longer built or shipped from this repository. Existing users must migrate to another model provider, such as Microsoft Foundry.

Validation:

  • .\build.cmd /p:SkipNativeBuild=true
  • dotnet test --project tests\Infrastructure.Tests\Infrastructure.Tests.csproj --no-launch-profile -- --filter-class "*.SelectTestsAcceptanceTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"

Fixes #18953

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 1, 2026 19:57
@eerhardt Eric Erhardt (eerhardt) added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19848

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19848"

@github-actions github-actions Bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Sep 1, 2026
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Active component documentation still presents the retired GitHub Models service as supported.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Removes the retired GitHub Models hosting integration while preserving its CLI blocklist entry and historical release notes.

Changes:

  • Deletes the integration, API baselines, tests, polyglot fixtures, and playground.
  • Removes associated solution entries and connection-property documentation.
  • Leaves several active component docs/comments still advertising GitHub Models support.
File summaries
File Description
tests/PolyglotAppHosts/Aspire.Hosting.GitHub.Models/TypeScript/tsconfig.json Removes TypeScript fixture configuration.
tests/PolyglotAppHosts/Aspire.Hosting.GitHub.Models/TypeScript/package.json Removes TypeScript fixture package definition.
tests/PolyglotAppHosts/Aspire.Hosting.GitHub.Models/TypeScript/package-lock.json Removes TypeScript dependency lock.
tests/PolyglotAppHosts/Aspire.Hosting.GitHub.Models/TypeScript/aspire.config.json Removes TypeScript AppHost configuration.
tests/PolyglotAppHosts/Aspire.Hosting.GitHub.Models/TypeScript/apphost.mts Removes TypeScript API fixture.
tests/PolyglotAppHosts/Aspire.Hosting.GitHub.Models/Python/pylock.apphost.toml Removes Python lock file.
tests/PolyglotAppHosts/Aspire.Hosting.GitHub.Models/Python/aspire.config.json Removes Python AppHost configuration.
tests/PolyglotAppHosts/Aspire.Hosting.GitHub.Models/Python/apphost.py Removes Python API fixture.
tests/PolyglotAppHosts/Aspire.Hosting.GitHub.Models/Python/apphost_requirements.txt Removes Python requirements.
tests/PolyglotAppHosts/Aspire.Hosting.GitHub.Models/Java/aspire.config.json Removes Java AppHost configuration.
tests/PolyglotAppHosts/Aspire.Hosting.GitHub.Models/Java/AppHost.java Removes Java API fixture.
tests/PolyglotAppHosts/Aspire.Hosting.GitHub.Models/Go/go.mod Removes Go module definition.
tests/PolyglotAppHosts/Aspire.Hosting.GitHub.Models/Go/aspire.config.json Removes Go AppHost configuration.
tests/PolyglotAppHosts/Aspire.Hosting.GitHub.Models/Go/apphost.go Removes Go API fixture.
tests/Aspire.Hosting.GitHub.Models.Tests/GitHubModelsFunctionalTests.cs Removes functional coverage.
tests/Aspire.Hosting.GitHub.Models.Tests/GitHubModelsExtensionTests.cs Removes extension-method coverage.
tests/Aspire.Hosting.GitHub.Models.Tests/ConnectionPropertiesTests.cs Removes connection-property coverage.
tests/Aspire.Hosting.GitHub.Models.Tests/Aspire.Hosting.GitHub.Models.Tests.csproj Removes the test project.
src/Aspire.Hosting.GitHub.Models/README.md Removes integration documentation.
src/Aspire.Hosting.GitHub.Models/GitHubModelsHealthCheck.cs Removes the health check.
src/Aspire.Hosting.GitHub.Models/GitHubModelsExtensions.cs Removes hosting APIs.
src/Aspire.Hosting.GitHub.Models/GitHubModelsDeprecation.cs Removes deprecation metadata.
src/Aspire.Hosting.GitHub.Models/GitHubModelResource.cs Removes the resource model.
src/Aspire.Hosting.GitHub.Models/GitHubModel.Obsolete.cs Removes obsolete catalog entries.
src/Aspire.Hosting.GitHub.Models/GitHubModel.Generated.cs Removes generated model catalog.
src/Aspire.Hosting.GitHub.Models/GithubModel.cs Removes the model descriptor.
src/Aspire.Hosting.GitHub.Models/build/Aspire.Hosting.GitHub.Models.props Removes package build imports.
src/Aspire.Hosting.GitHub.Models/Aspire.Hosting.GitHub.Models.csproj Removes the product project.
src/Aspire.Hosting.GitHub.Models/api/Aspire.Hosting.GitHub.Models.cs Removes the .NET API baseline.
src/Aspire.Hosting.GitHub.Models/api/Aspire.Hosting.GitHub.Models.ats.txt Removes the ATS baseline.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.WebStory/wwwroot/app.css Removes playground styling.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.WebStory/Properties/launchSettings.json Removes web launch settings.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.WebStory/Program.cs Removes web application startup.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.WebStory/GitHubModelsEndToEnd.WebStory.csproj Removes the web project.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.WebStory/Components/Routes.razor Removes playground routing.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.WebStory/Components/Pages/Home.razor Removes the model demo page.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.WebStory/Components/Pages/Error.razor Removes the error page.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.WebStory/Components/Layout/MainLayout.razor.css Removes layout styling.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.WebStory/Components/Layout/MainLayout.razor Removes the main layout.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.WebStory/Components/App.razor Removes the Blazor application shell.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.WebStory/Components/_Imports.razor Removes Razor imports.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.WebStory/appsettings.json Removes web settings.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.WebStory/appsettings.Development.json Removes development settings.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.AppHost/webstory.module.bicep Removes generated deployment infrastructure.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.AppHost/webstory-containerapp.module.bicep Removes Container Apps infrastructure.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.AppHost/Properties/launchSettings.json Removes AppHost launch settings.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.AppHost/GitHubModelsEndToEnd.AppHost.csproj Removes the AppHost project.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.AppHost/env.module.bicep Removes environment infrastructure.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.AppHost/env-acr.module.bicep Removes registry infrastructure.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.AppHost/aspire-manifest.json Removes the deployment manifest.
playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.AppHost/AppHost.cs Removes the playground resource model.
playground/GitHubModelsEndToEnd/aspire.config.json Removes playground configuration.
playground/GitHubModelsEndToEnd/.vscode/launch.json Removes playground debugger configuration.
playground/AspireWithMaui/AspireWithMaui.slnx Removes integration, test, and playground entries.
docs/specs/connection-properties.md Removes GitHub Model property references.
Aspire.slnx Removes integration, test, and playground projects.
Review details

Files not reviewed (1)

  • tests/PolyglotAppHosts/Aspire.Hosting.GitHub.Models/TypeScript/package-lock.json: Generated file
  • Files reviewed: 55/56 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread docs/specs/connection-properties.md
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 871a7326-8679-43f9-ae22-325bb9e2c0ca
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Tests selector

Selects the full PR test matrix + all PR-gated jobs (ALL) — a rule matching 'Aspire.slnx' selects ALL

Advisory workflow impact (4)

  • Aspire.Deployment.EndToEnd.Tests (deployment workflow-only)
  • Aspire.EndToEnd.Tests (outerloop-only)
  • Aspire.Oracle.EntityFrameworkCore.Tests (outerloop-only)
  • deployment-e2e (schedule/dispatch-only)

Selection computed for commit e818020.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The retired integration and its dependent artifacts are consistently removed while the deprecated package blocklist remains intact.

Review details

Files not reviewed (1)

  • tests/PolyglotAppHosts/Aspire.Hosting.GitHub.Models/TypeScript/package-lock.json: Generated file
  • Files reviewed: 58/59 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Github Model resources

5 participants