fix: correct sample requirements and standardize config template naming#7057
Open
Ahmed-Farouk10 wants to merge 2 commits into
Open
Conversation
02_multi_agent imports OpenAIChatCompletionClient from agent_framework.openai but its requirements.txt referenced packages/foundry instead of packages/openai. The sample works because openai is a transitive dependency of core, but the requirements file should directly reference the package it actually uses.
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Durable Task multi-agent Python sample’s requirements.txt to explicitly depend on the OpenAI package (matching the sample’s OpenAIChatCompletionClient usage) rather than the Foundry package, avoiding reliance on transitive dependencies.
Changes:
- Corrected the commented PyPI package reference from
agent-framework-foundrytoagent-framework-openai. - Switched the local editable dependency from
packages/foundrytopackages/openai. - Updated the inline comment to accurately describe the OpenAI dependency.
azure_functions samples 01-08 use .template, but 09-13 used .sample. This inconsistency broke the parent README instructions which reference .template files. Standardized all samples to .template. Also renamed .env.sample to .env.template in sample 10. Closes microsoft#5399
Ahmed-Farouk10
changed the title
giles17
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
1. Wrong package reference (durabletask/02-multi-agent)
\worker.py\ imports \OpenAIChatCompletionClient\ from \�gent_framework.openai, but
equirements.txt\ referenced \packages/foundry\ instead of \packages/openai. The sample works because \openai\ is a transitive dependency of \core, but the explicit dependency was misleading.
2. Inconsistent config template naming (azure_functions)
Samples 01-08 used .template\ suffix while 09-13 used .sample. The parent README instructs users to copy .template\ files, which didn't exist in the later samples.
Changes
requirements.txt fix
Config template standardization
Files changed