Only normalize intersections that include {} by ahejlsberg · Pull Request #50535 · microsoft/TypeScript

ahejlsberg · 2022-08-30T14:42:41Z

ahejlsberg · 2022-08-30T14:44:00Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2022-08-30T14:44:07Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 698c3ab. You can monitor the build here.

typescript-bot · 2022-08-30T14:44:07Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 698c3ab. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-08-30T14:44:07Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 698c3ab. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-08-30T14:44:07Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 698c3ab. You can monitor the build here.

typescript-bot · 2022-08-30T14:44:07Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 698c3ab. You can monitor the build here.

typescript-bot · 2022-08-30T14:59:13Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/50535/merge:

Everything looks good!

typescript-bot · 2022-08-30T15:04:36Z

Heya @ahejlsberg, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

typescript-bot · 2022-08-30T15:08:37Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..50535

_Metric	_main	₅₀₅₃₅	_Delta	_Best	_Worst
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{338,727k (± 0.00%)}	_{338,739k (± 0.01%)}	_{+12k (+ 0.00%)}	_338,694k	_338,796k
_{Parse Time}	_{2.08s (± 0.70%)}	_{2.07s (± 0.60%)}	_{-0.01s (- 0.34%)}	_2.05s	_2.11s
_{Bind Time}	_{0.80s (± 0.62%)}	_{0.79s (± 0.28%)}	_{-0.00s (- 0.63%)}	_0.79s	_0.80s
_{Check Time}	_{5.82s (± 0.58%)}	_{5.82s (± 0.39%)}	_{-0.01s (- 0.10%)}	_5.78s	_5.88s
_{Emit Time}	_{6.18s (± 0.49%)}	_{6.15s (± 0.59%)}	_{-0.03s (- 0.53%)}	_6.05s	_6.22s
_{Total Time}	_{14.87s (± 0.27%)}	_{14.82s (± 0.26%)}	_{-0.05s (- 0.32%)}	_14.74s	_14.90s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{192,654k (± 0.02%)}	_{192,634k (± 0.02%)}	_{-20k (- 0.01%)}	_192,555k	_192,686k
_{Parse Time}	_{0.86s (± 0.52%)}	_{0.85s (± 1.04%)}	_{-0.00s (- 0.47%)}	_0.84s	_0.88s
_{Bind Time}	_{0.49s (± 0.75%)}	_{0.48s (± 0.70%)}	_{-0.00s (- 0.62%)}	_0.48s	_0.49s
_{Check Time}	_{6.70s (± 0.55%)}	_{6.68s (± 0.46%)}	_{-0.02s (- 0.30%)}	_6.63s	_6.77s
_{Emit Time}	_{2.41s (± 1.02%)}	_{2.39s (± 0.74%)}	_{-0.02s (- 0.83%)}	_2.36s	_2.43s
_{Total Time}	_{10.46s (± 0.45%)}	_{10.41s (± 0.36%)}	_{-0.05s (- 0.47%)}	_10.33s	_10.48s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{326,505k (± 0.01%)}	_{326,510k (± 0.01%)}	_{+4k (+ 0.00%)}	_326,457k	_326,554k
_{Parse Time}	_{1.57s (± 0.59%)}	_{1.57s (± 0.88%)}	_{+0.00s (+ 0.13%)}	_1.55s	_1.61s
_{Bind Time}	_{0.73s (± 0.85%)}	_{0.72s (± 0.94%)}	_{-0.01s (- 0.69%)}	_0.71s	_0.74s
_{Check Time}	_{5.73s (± 0.51%)}	_{5.69s (± 0.44%)}	_{-0.04s (- 0.66%)}	_5.64s	_5.74s
_{Emit Time}	_{3.35s (± 0.61%)}	_{3.31s (± 0.67%)}	_{-0.04s (- 1.31%)}	_3.26s	_3.35s
_{Total Time}	_{11.39s (± 0.42%)}	_{11.30s (± 0.41%)}	_{-0.09s (- 0.77%)}	_11.20s	_11.40s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{289,645k (± 0.00%)}	_{289,632k (± 0.01%)}	_{-13k (- 0.00%)}	_289,597k	_289,683k
_{Parse Time}	_{1.31s (± 0.83%)}	_{1.31s (± 1.25%)}	_{-0.00s (- 0.23%)}	_1.25s	_1.33s
_{Bind Time}	_{0.78s (± 2.29%)}	_{0.79s (± 1.07%)}	_{+0.00s (+ 0.64%)}	_0.76s	_0.80s
_{Check Time}	_{5.36s (± 0.54%)}	_{5.31s (± 1.08%)}	_{-0.05s (- 0.99%)}	_5.09s	_5.37s
_{Emit Time}	_{3.60s (± 0.77%)}	_{3.54s (± 1.24%)}	_{-0.06s (- 1.75%)}	_3.37s	_3.58s
_{Total Time}	_{11.05s (± 0.38%)}	_{10.94s (± 1.10%)}	_{-0.11s (- 1.04%)}	_10.47s	_11.06s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{438,087k (± 0.06%)}	_{435,894k (± 0.00%)}	_{-2,193k (- 0.50%)}	_435,866k	_435,935k
_{Parse Time}	_{1.86s (± 0.59%)}	_{1.85s (± 0.39%)}	_{-0.02s (- 0.81%)}	_1.84s	_1.87s
_{Bind Time}	_{0.59s (± 0.62%)}	_{0.58s (± 0.59%)}	_{-0.01s (- 1.54%)}	_0.57s	_0.58s
_{Check Time}	_{13.06s (± 0.95%)}	_{12.87s (± 1.34%)}	_{-0.19s (- 1.46%)}	_12.68s	_13.54s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.51s (± 0.81%)}	_{15.29s (± 1.11%)}	_{-0.21s (- 1.38%)}	_15.11s	_15.96s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{547,388k (± 0.00%)}	_{546,742k (± 0.00%)}	_{-646k (- 0.12%)}	_546,716k	_546,774k
_{Parse Time}	_{2.60s (± 0.45%)}	_{2.59s (± 0.66%)}	_{-0.01s (- 0.23%)}	_2.58s	_2.66s
_{Bind Time}	_{0.97s (± 0.70%)}	_{0.97s (± 1.18%)}	_{-0.01s (- 0.62%)}	_0.96s	_1.01s
_{Check Time}	_{1.54s (± 0.62%)}	_{1.52s (± 0.48%)}	_{-0.03s (- 1.68%)}	_1.50s	_1.53s
_{Emit Time}	_{0.07s (± 4.13%)}	_{0.07s (± 4.66%)}	_{+0.00s (+ 1.39%)}	_0.07s	_0.08s
_{Total Time}	_{5.20s (± 0.42%)}	_{5.15s (± 0.44%)}	_{-0.05s (- 0.92%)}	_5.11s	_5.23s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v14.15.1, x64)

Scenarios

Angular - node (v14.15.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₀₅₃₅	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

DanielRosenwasser · 2022-08-30T17:33:25Z

 tests/cases/conformance/types/conditional/conditionalTypes2.ts(75,12): error TS2345: Argument of type 'Extract2<T, Foo, Bar>' is not assignable to parameter of type '{ foo: string; bat: string; }'.
  Type 'T extends Bar ? T : never' is not assignable to type '{ foo: string; bat: string; }'.
-    Type 'Bar & Foo & T' is not assignable to type '{ foo: string; bat: string; }'.
+    Property 'bat' is missing in type 'Bar & Foo' but required in type '{ foo: string; bat: string; }'.


This is really the only test that's affected? We don't have any other tests that try to intersect a type with {}?

We have plenty of those, but what you're seeing here is the difference between normalizing all intersections in relationship checking vs. just normalizing intersections containing {}. Previously we didn't normalize intersections at all, relying instead on normalizing each individual constituent as we broke down the intersection in relationship checking. That worked when NonNullable<T> was a conditional type, but not with the new representation.

RyanCavanaugh · 2022-08-30T19:38:05Z

@typescript-bot cherry-pick this to release-4.8

cc @andrewbranch

typescript-bot · 2022-08-30T19:38:09Z

Heya @RyanCavanaugh, I've started to run the task to cherry-pick this into release-4.8 on this PR at 698c3ab. You can monitor the build here.

typescript-bot · 2022-08-30T19:43:53Z

Hey @RyanCavanaugh, I've opened #50549 for you.

ahejlsberg · 2022-08-30T22:29:20Z

@typescript-bot test top100

typescript-bot · 2022-08-30T22:29:21Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 698c3ab. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-08-31T00:04:12Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/50535/merge:

Everything looks good!

ahejlsberg · 2022-08-31T04:49:28Z

Tests are all clean and perf looks good. This one is ready to merge.

ahejlsberg added 2 commits August 30, 2022 07:41

Only normalize intersections that include {}

7bd2a6e

Accept new baselines

698c3ab

typescript-bot assigned ahejlsberg Aug 30, 2022

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 30, 2022

ahejlsberg mentioned this pull request Aug 30, 2022

Performance issue on updating Babel monorepo typescript from 4.7.4 to 4.8.2 #50515

Closed

DanielRosenwasser reviewed Aug 30, 2022

View reviewed changes

typescript-bot mentioned this pull request Aug 30, 2022

🤖 Pick PR #50535 (Only normalize intersections that i...) into release-4.8 #50549

Merged

ahejlsberg mentioned this pull request Aug 30, 2022

Defer distributing index over generic object types #50540

Merged

weswigham approved these changes Aug 31, 2022

View reviewed changes

andrewbranch approved these changes Aug 31, 2022

View reviewed changes

andrewbranch added this to the TypeScript 4.8.3 milestone Aug 31, 2022

typescript-bot removed the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 31, 2022

typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Aug 31, 2022

ahejlsberg merged commit 43f8ae6 into main Aug 31, 2022

ahejlsberg deleted the fix50515 branch August 31, 2022 21:36

Andarist mentioned this pull request Mar 7, 2024

Fixed excess and common property checks with NoInfer #57673

Merged

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

Conversation

ahejlsberg commented Aug 30, 2022

Uh oh!

ahejlsberg commented Aug 30, 2022

Uh oh!

typescript-bot commented Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 30, 2022

Uh oh!

typescript-bot commented Aug 30, 2022

Uh oh!

typescript-bot commented Aug 30, 2022

Uh oh!

DanielRosenwasser Aug 30, 2022

Choose a reason for hiding this comment

Uh oh!

ahejlsberg Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RyanCavanaugh commented Aug 30, 2022

Uh oh!

typescript-bot commented Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 30, 2022

Uh oh!

ahejlsberg commented Aug 30, 2022

Uh oh!

typescript-bot commented Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 31, 2022

Uh oh!

ahejlsberg commented Aug 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

typescript-bot commented Aug 30, 2022 •

edited

Loading

typescript-bot commented Aug 30, 2022 •

edited

Loading

typescript-bot commented Aug 30, 2022 •

edited

Loading

typescript-bot commented Aug 30, 2022 •

edited

Loading

typescript-bot commented Aug 30, 2022 •

edited

Loading

ahejlsberg Aug 30, 2022 •

edited

Loading

typescript-bot commented Aug 30, 2022 •

edited

Loading

typescript-bot commented Aug 30, 2022 •

edited

Loading