fix(50340): typeof ... === "undefined" check on discriminated union of undefined and object type doesn't narrow correctly

[a-tarasyuk]

Fixes #50340

[DanielRosenwasser]

@typescript-bot test this
@typescript-bot user test this
@typescript-bot perf test this

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at b4e02ab. You can monitor the build here.

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at b4e02ab. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at b4e02ab. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/50344/merge:

Everything looks good!

[typescript-bot]

Heya @DanielRosenwasser, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

[typescript-bot]

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..50344

Metric	main	50344	Delta	Best	Worst
Angular - node (v10.16.3, x64)
Memory used	362,074k (± 0.02%)	362,250k (± 0.02%)	+176k (+ 0.05%)	362,094k	362,466k
Parse Time	2.10s (± 0.62%)	2.10s (± 0.55%)	-0.00s (- 0.19%)	2.08s	2.12s
Bind Time	0.90s (± 1.48%)	0.89s (± 0.66%)	-0.01s (- 1.11%)	0.88s	0.91s
Check Time	6.07s (± 0.56%)	6.02s (± 0.31%)	-0.05s (- 0.79%)	5.95s	6.04s
Emit Time	6.15s (± 0.46%)	5.95s (± 0.53%)	🟩-0.20s (- 3.32%)	5.89s	6.04s
Total Time	15.22s (± 0.35%)	14.96s (± 0.24%)	-0.26s (- 1.72%)	14.90s	15.07s
Compiler-Unions - node (v10.16.3, x64)
Memory used	205,500k (± 0.04%)	205,800k (± 0.03%)	+299k (+ 0.15%)	205,615k	205,863k
Parse Time	0.83s (± 0.99%)	0.84s (± 0.98%)	+0.01s (+ 1.21%)	0.82s	0.85s
Bind Time	0.53s (± 1.32%)	0.52s (± 1.58%)	-0.01s (- 0.95%)	0.51s	0.55s
Check Time	7.39s (± 0.43%)	7.36s (± 0.37%)	-0.03s (- 0.39%)	7.29s	7.42s
Emit Time	2.50s (± 1.03%)	2.42s (± 1.11%)	🟩-0.08s (- 3.40%)	2.37s	2.50s
Total Time	11.25s (± 0.43%)	11.14s (± 0.46%)	-0.11s (- 1.00%)	11.02s	11.29s
Monaco - node (v10.16.3, x64)
Memory used	343,990k (± 0.03%)	344,144k (± 0.02%)	+154k (+ 0.04%)	344,027k	344,381k
Parse Time	1.60s (± 0.60%)	1.61s (± 0.46%)	+0.01s (+ 0.50%)	1.59s	1.62s
Bind Time	0.76s (± 1.33%)	0.76s (± 0.76%)	+0.00s (+ 0.53%)	0.75s	0.78s
Check Time	6.00s (± 0.45%)	6.02s (± 0.57%)	+0.01s (+ 0.25%)	5.91s	6.09s
Emit Time	3.27s (± 0.72%)	3.23s (± 0.86%)	-0.04s (- 1.22%)	3.17s	3.28s
Total Time	11.63s (± 0.36%)	11.61s (± 0.39%)	-0.02s (- 0.14%)	11.53s	11.73s
TFS - node (v10.16.3, x64)
Memory used	305,274k (± 0.02%)	305,347k (± 0.03%)	+73k (+ 0.02%)	305,052k	305,500k
Parse Time	1.29s (± 0.64%)	1.29s (± 0.59%)	0.00s ( 0.00%)	1.27s	1.30s
Bind Time	0.72s (± 0.47%)	0.72s (± 0.46%)	+0.00s (+ 0.42%)	0.71s	0.73s
Check Time	5.43s (± 0.55%)	5.45s (± 0.40%)	+0.01s (+ 0.26%)	5.40s	5.50s
Emit Time	3.43s (± 1.22%)	3.33s (± 1.17%)	-0.10s (- 2.83%)	3.25s	3.41s
Total Time	10.86s (± 0.60%)	10.78s (± 0.48%)	-0.08s (- 0.76%)	10.67s	10.89s
material-ui - node (v10.16.3, x64)
Memory used	472,967k (± 0.01%)	472,976k (± 0.01%)	+10k (+ 0.00%)	472,779k	473,097k
Parse Time	1.84s (± 0.76%)	1.84s (± 0.44%)	-0.00s (- 0.05%)	1.82s	1.86s
Bind Time	0.68s (± 1.39%)	0.68s (± 1.58%)	-0.00s (- 0.44%)	0.66s	0.70s
Check Time	14.51s (± 0.40%)	14.48s (± 0.54%)	-0.03s (- 0.19%)	14.34s	14.67s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	17.03s (± 0.39%)	17.00s (± 0.46%)	-0.03s (- 0.19%)	16.87s	17.18s
xstate - node (v10.16.3, x64)
Memory used	582,772k (± 0.01%)	582,973k (± 0.01%)	+201k (+ 0.03%)	582,792k	583,192k
Parse Time	2.60s (± 0.42%)	2.60s (± 0.34%)	-0.00s (- 0.19%)	2.58s	2.62s
Bind Time	1.05s (± 0.53%)	1.04s (± 0.74%)	-0.01s (- 0.67%)	1.02s	1.05s
Check Time	1.57s (± 0.77%)	1.57s (± 0.64%)	-0.00s (- 0.00%)	1.54s	1.59s
Emit Time	0.07s (± 3.14%)	0.07s (± 0.00%)	-0.00s (- 1.41%)	0.07s	0.07s
Total Time	5.29s (± 0.34%)	5.28s (± 0.22%)	-0.01s (- 0.25%)	5.26s	5.31s
Angular - node (v12.1.0, x64)
Memory used	339,511k (± 0.02%)	339,506k (± 0.09%)	-5k (- 0.00%)	338,350k	339,799k
Parse Time	2.09s (± 0.50%)	2.10s (± 0.45%)	+0.01s (+ 0.72%)	2.08s	2.13s
Bind Time	0.86s (± 1.14%)	0.87s (± 1.03%)	+0.00s (+ 0.46%)	0.85s	0.89s
Check Time	5.83s (± 0.32%)	5.88s (± 0.91%)	+0.05s (+ 0.82%)	5.77s	6.06s
Emit Time	6.35s (± 0.78%)	6.24s (± 1.08%)	-0.10s (- 1.65%)	6.14s	6.46s
Total Time	15.13s (± 0.38%)	15.09s (± 0.57%)	-0.04s (- 0.26%)	14.90s	15.34s
Compiler-Unions - node (v12.1.0, x64)
Memory used	193,213k (± 0.03%)	193,507k (± 0.02%)	+294k (+ 0.15%)	193,397k	193,639k
Parse Time	0.82s (± 0.70%)	0.82s (± 0.81%)	-0.00s (- 0.36%)	0.81s	0.84s
Bind Time	0.55s (± 0.62%)	0.55s (± 0.62%)	0.00s ( 0.00%)	0.54s	0.55s
Check Time	6.90s (± 0.64%)	6.88s (± 0.33%)	-0.01s (- 0.19%)	6.85s	6.96s
Emit Time	2.53s (± 0.75%)	2.46s (± 1.00%)	-0.07s (- 2.73%)	2.39s	2.51s
Total Time	10.79s (± 0.39%)	10.71s (± 0.29%)	-0.09s (- 0.82%)	10.66s	10.80s
Monaco - node (v12.1.0, x64)
Memory used	326,963k (± 0.02%)	327,067k (± 0.03%)	+104k (+ 0.03%)	326,908k	327,320k
Parse Time	1.57s (± 0.67%)	1.57s (± 0.95%)	0.00s ( 0.00%)	1.54s	1.60s
Bind Time	0.74s (± 0.70%)	0.74s (± 0.70%)	+0.00s (+ 0.27%)	0.73s	0.75s
Check Time	5.80s (± 0.51%)	5.83s (± 0.56%)	+0.02s (+ 0.41%)	5.77s	5.93s
Emit Time	3.29s (± 0.75%)	3.28s (± 0.78%)	-0.01s (- 0.36%)	3.23s	3.34s
Total Time	11.40s (± 0.44%)	11.42s (± 0.56%)	+0.02s (+ 0.15%)	11.28s	11.58s
TFS - node (v12.1.0, x64)
Memory used	289,915k (± 0.02%)	289,889k (± 0.02%)	-25k (- 0.01%)	289,782k	290,034k
Parse Time	1.31s (± 0.73%)	1.30s (± 1.22%)	-0.00s (- 0.23%)	1.28s	1.34s
Bind Time	0.72s (± 0.69%)	0.72s (± 0.46%)	+0.00s (+ 0.56%)	0.71s	0.73s
Check Time	5.38s (± 0.50%)	5.37s (± 0.76%)	-0.01s (- 0.24%)	5.23s	5.44s
Emit Time	3.54s (± 0.90%)	3.47s (± 0.72%)	-0.06s (- 1.75%)	3.42s	3.53s
Total Time	10.94s (± 0.48%)	10.86s (± 0.53%)	-0.08s (- 0.69%)	10.71s	10.97s
material-ui - node (v12.1.0, x64)
Memory used	451,940k (± 0.01%)	451,858k (± 0.06%)	-81k (- 0.02%)	450,750k	452,140k
Parse Time	1.82s (± 0.45%)	1.83s (± 0.77%)	+0.01s (+ 0.33%)	1.81s	1.88s
Bind Time	0.67s (± 0.66%)	0.67s (± 0.51%)	+0.00s (+ 0.15%)	0.67s	0.68s
Check Time	13.03s (± 0.64%)	13.02s (± 0.52%)	-0.01s (- 0.05%)	12.87s	13.18s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	15.53s (± 0.54%)	15.53s (± 0.46%)	+0.00s (+ 0.01%)	15.35s	15.67s
xstate - node (v12.1.0, x64)
Memory used	548,019k (± 0.02%)	548,116k (± 0.02%)	+97k (+ 0.02%)	547,954k	548,377k
Parse Time	2.54s (± 0.35%)	2.54s (± 0.50%)	+0.01s (+ 0.24%)	2.51s	2.57s
Bind Time	1.03s (± 1.18%)	1.03s (± 1.06%)	-0.00s (- 0.29%)	1.00s	1.06s
Check Time	1.51s (± 0.48%)	1.51s (± 0.56%)	-0.00s (- 0.07%)	1.49s	1.53s
Emit Time	0.07s (± 0.00%)	0.07s (± 0.00%)	0.00s ( 0.00%)	0.07s	0.07s
Total Time	5.14s (± 0.41%)	5.15s (± 0.36%)	+0.01s (+ 0.14%)	5.12s	5.20s
Angular - node (v14.15.1, x64)
Memory used	337,670k (± 0.01%)	337,751k (± 0.01%)	+81k (+ 0.02%)	337,697k	337,829k
Parse Time	2.07s (± 0.75%)	2.07s (± 0.71%)	-0.00s (- 0.10%)	2.05s	2.12s
Bind Time	0.90s (± 0.41%)	0.90s (± 0.90%)	+0.00s (+ 0.45%)	0.89s	0.93s
Check Time	5.85s (± 0.50%)	5.83s (± 0.41%)	-0.02s (- 0.27%)	5.78s	5.88s
Emit Time	6.37s (± 0.61%)	6.15s (± 0.60%)	🟩-0.22s (- 3.41%)	6.09s	6.25s
Total Time	15.18s (± 0.39%)	14.95s (± 0.42%)	-0.23s (- 1.53%)	14.84s	15.11s
Compiler-Unions - node (v14.15.1, x64)
Memory used	191,804k (± 0.02%)	191,992k (± 0.02%)	+188k (+ 0.10%)	191,946k	192,084k
Parse Time	0.85s (± 0.78%)	0.85s (± 0.56%)	+0.00s (+ 0.35%)	0.84s	0.86s
Bind Time	0.58s (± 0.58%)	0.58s (± 0.63%)	-0.01s (- 1.20%)	0.57s	0.58s
Check Time	6.95s (± 0.67%)	6.92s (± 0.64%)	-0.03s (- 0.39%)	6.83s	7.01s
Emit Time	2.49s (± 0.83%)	2.41s (± 1.02%)	-0.07s (- 2.90%)	2.37s	2.49s
Total Time	10.86s (± 0.49%)	10.76s (± 0.56%)	-0.10s (- 0.90%)	10.65s	10.89s
Monaco - node (v14.15.1, x64)
Memory used	325,778k (± 0.00%)	325,901k (± 0.01%)	+123k (+ 0.04%)	325,863k	325,937k
Parse Time	1.57s (± 0.51%)	1.57s (± 0.48%)	-0.00s (- 0.06%)	1.55s	1.59s
Bind Time	0.78s (± 0.87%)	0.78s (± 0.74%)	-0.00s (- 0.51%)	0.77s	0.79s
Check Time	5.72s (± 0.59%)	5.71s (± 0.74%)	-0.01s (- 0.24%)	5.61s	5.79s
Emit Time	3.36s (± 0.98%)	3.32s (± 0.64%)	-0.04s (- 1.22%)	3.28s	3.38s
Total Time	11.43s (± 0.46%)	11.37s (± 0.44%)	-0.06s (- 0.52%)	11.26s	11.47s
TFS - node (v14.15.1, x64)
Memory used	288,879k (± 0.01%)	288,983k (± 0.01%)	+103k (+ 0.04%)	288,919k	289,032k
Parse Time	1.35s (± 1.40%)	1.35s (± 2.02%)	+0.00s (+ 0.30%)	1.30s	1.43s
Bind Time	0.74s (± 3.34%)	0.75s (± 3.85%)	+0.01s (+ 1.48%)	0.73s	0.84s
Check Time	5.35s (± 0.41%)	5.35s (± 0.48%)	-0.00s (- 0.02%)	5.29s	5.40s
Emit Time	3.58s (± 2.22%)	3.47s (± 2.20%)	🟩-0.11s (- 3.13%)	3.35s	3.62s
Total Time	11.03s (± 0.78%)	10.93s (± 0.72%)	-0.10s (- 0.92%)	10.78s	11.15s
material-ui - node (v14.15.1, x64)
Memory used	450,188k (± 0.01%)	449,993k (± 0.08%)	-196k (- 0.04%)	448,921k	450,319k
Parse Time	1.88s (± 0.61%)	1.88s (± 0.65%)	+0.00s (+ 0.11%)	1.86s	1.91s
Bind Time	0.71s (± 0.63%)	0.72s (± 0.62%)	+0.01s (+ 0.84%)	0.71s	0.73s
Check Time	13.10s (± 0.51%)	13.13s (± 0.69%)	+0.03s (+ 0.21%)	12.95s	13.36s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	15.69s (± 0.45%)	15.73s (± 0.57%)	+0.03s (+ 0.22%)	15.56s	15.97s
xstate - node (v14.15.1, x64)
Memory used	545,659k (± 0.00%)	545,821k (± 0.00%)	+162k (+ 0.03%)	545,753k	545,874k
Parse Time	2.61s (± 0.69%)	2.61s (± 0.26%)	-0.00s (- 0.19%)	2.60s	2.63s
Bind Time	1.14s (± 0.71%)	1.14s (± 0.70%)	-0.00s (- 0.44%)	1.12s	1.16s
Check Time	1.55s (± 0.40%)	1.55s (± 0.60%)	+0.00s (+ 0.06%)	1.54s	1.57s
Emit Time	0.08s (± 4.79%)	0.07s (± 4.95%)	-0.00s (- 1.32%)	0.07s	0.08s
Total Time	5.37s (± 0.21%)	5.37s (± 0.17%)	-0.00s (- 0.07%)	5.35s	5.38s

System

Machine Name	ts-ci-ubuntu
Platform	linux 4.4.0-210-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v10.16.3, x64)
• node (v12.1.0, x64)
• node (v14.15.1, x64)

Scenarios

• Angular - node (v10.16.3, x64)
• Angular - node (v12.1.0, x64)
• Angular - node (v14.15.1, x64)
• Compiler-Unions - node (v10.16.3, x64)
• Compiler-Unions - node (v12.1.0, x64)
• Compiler-Unions - node (v14.15.1, x64)
• Monaco - node (v10.16.3, x64)
• Monaco - node (v12.1.0, x64)
• Monaco - node (v14.15.1, x64)
• TFS - node (v10.16.3, x64)
• TFS - node (v12.1.0, x64)
• TFS - node (v14.15.1, x64)
• material-ui - node (v10.16.3, x64)
• material-ui - node (v12.1.0, x64)
• material-ui - node (v14.15.1, x64)
• xstate - node (v10.16.3, x64)
• xstate - node (v12.1.0, x64)
• xstate - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	50344	10
Baseline	main	10

TSServer

Comparison Report - main..50344

Metric	main	50344	Delta	Best	Worst
Compiler-UnionsTSServer - node (v10.16.3, x64)
Req 1 - updateOpen	1,453ms (± 0.48%)	1,453ms (± 0.58%)	0ms ( 0.00%)	1,434ms	1,472ms
Req 2 - geterr	3,793ms (± 0.52%)	3,783ms (± 0.54%)	-10ms (- 0.26%)	3,709ms	3,808ms
Req 3 - references	276ms (± 0.73%)	276ms (± 1.18%)	+0ms (+ 0.11%)	272ms	284ms
Req 4 - navto	233ms (± 0.84%)	230ms (± 2.07%)	-3ms (- 1.41%)	212ms	235ms
Req 5 - completionInfo count	1,355 (± 0.00%)	1,355 (± 0.00%)	0 ( 0.00%)	1,355	1,355
Req 5 - completionInfo	66ms (± 5.40%)	62ms (± 2.42%)	🟩-4ms (- 5.48%)	59ms	66ms
CompilerTSServer - node (v10.16.3, x64)
Req 1 - updateOpen	1,564ms (± 0.53%)	1,555ms (± 0.63%)	-10ms (- 0.62%)	1,532ms	1,575ms
Req 2 - geterr	2,273ms (± 0.58%)	2,273ms (± 0.51%)	+0ms (+ 0.01%)	2,244ms	2,293ms
Req 3 - references	295ms (± 0.81%)	296ms (± 0.42%)	+1ms (+ 0.37%)	293ms	299ms
Req 4 - navto	236ms (± 1.73%)	236ms (± 1.63%)	+0ms (+ 0.08%)	227ms	241ms
Req 5 - completionInfo count	1,517 (± 0.00%)	1,517 (± 0.00%)	0 ( 0.00%)	1,517	1,517
Req 5 - completionInfo	68ms (± 1.77%)	68ms (± 2.10%)	+0ms (+ 0.30%)	65ms	70ms
xstateTSServer - node (v10.16.3, x64)
Req 1 - updateOpen	2,177ms (± 0.37%)	2,172ms (± 0.36%)	-4ms (- 0.19%)	2,153ms	2,183ms
Req 2 - geterr	777ms (± 0.61%)	771ms (± 0.40%)	-6ms (- 0.77%)	762ms	778ms
Req 3 - references	99ms (± 0.90%)	98ms (± 0.86%)	-1ms (- 0.71%)	96ms	99ms
Req 4 - navto	250ms (± 0.96%)	250ms (± 0.92%)	+0ms (+ 0.04%)	243ms	254ms
Req 5 - completionInfo count	3,345 (± 0.00%)	3,345 (± 0.00%)	0 ( 0.00%)	3,345	3,345
Req 5 - completionInfo	275ms (± 1.63%)	270ms (± 0.97%)	-6ms (- 2.11%)	263ms	275ms
Compiler-UnionsTSServer - node (v12.1.0, x64)
Req 1 - updateOpen	1,474ms (± 0.80%)	1,484ms (± 0.80%)	+10ms (+ 0.65%)	1,455ms	1,509ms
Req 2 - geterr	3,542ms (± 0.56%)	3,533ms (± 0.55%)	-9ms (- 0.25%)	3,479ms	3,565ms
Req 3 - references	261ms (± 1.11%)	265ms (± 2.73%)	+4ms (+ 1.50%)	258ms	292ms
Req 4 - navto	203ms (± 1.06%)	203ms (± 0.68%)	0ms ( 0.00%)	198ms	205ms
Req 5 - completionInfo count	1,355 (± 0.00%)	1,355 (± 0.00%)	0 ( 0.00%)	1,355	1,355
Req 5 - completionInfo	80ms (±11.25%)	63ms (±14.93%)	🟩-17ms (-21.64%)	55ms	91ms
CompilerTSServer - node (v12.1.0, x64)
Req 1 - updateOpen	1,570ms (± 0.68%)	1,568ms (± 0.48%)	-3ms (- 0.17%)	1,551ms	1,581ms
Req 2 - geterr	2,213ms (± 0.38%)	2,210ms (± 0.34%)	-3ms (- 0.11%)	2,191ms	2,224ms
Req 3 - references	273ms (± 0.49%)	274ms (± 0.71%)	+1ms (+ 0.33%)	270ms	278ms
Req 4 - navto	213ms (± 0.52%)	213ms (± 1.08%)	-1ms (- 0.28%)	210ms	220ms
Req 5 - completionInfo count	1,517 (± 0.00%)	1,517 (± 0.00%)	0 ( 0.00%)	1,517	1,517
Req 5 - completionInfo	62ms (± 4.54%)	64ms (± 4.16%)	+2ms (+ 3.40%)	54ms	68ms
xstateTSServer - node (v12.1.0, x64)
Req 1 - updateOpen	2,110ms (± 0.29%)	2,125ms (± 0.35%)	+14ms (+ 0.68%)	2,105ms	2,139ms
Req 2 - geterr	756ms (± 0.87%)	755ms (± 0.32%)	-1ms (- 0.11%)	749ms	760ms
Req 3 - references	68ms (± 1.39%)	66ms (± 0.89%)	-1ms (- 1.92%)	65ms	68ms
Req 4 - navto	240ms (± 0.90%)	241ms (± 1.00%)	+1ms (+ 0.37%)	234ms	247ms
Req 5 - completionInfo count	3,345 (± 0.00%)	3,345 (± 0.00%)	0 ( 0.00%)	3,345	3,345
Req 5 - completionInfo	268ms (± 0.98%)	268ms (± 0.52%)	+0ms (+ 0.11%)	265ms	271ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	1,526ms (± 0.19%)	1,531ms (± 0.53%)	+5ms (+ 0.31%)	1,514ms	1,554ms
Req 2 - geterr	3,660ms (± 0.66%)	3,690ms (± 0.71%)	+30ms (+ 0.82%)	3,646ms	3,755ms
Req 3 - references	276ms (± 0.55%)	278ms (± 1.09%)	+2ms (+ 0.80%)	272ms	284ms
Req 4 - navto	218ms (± 0.74%)	220ms (± 1.10%)	+2ms (+ 1.01%)	215ms	227ms
Req 5 - completionInfo count	1,355 (± 0.00%)	1,355 (± 0.00%)	0 ( 0.00%)	1,355	1,355
Req 5 - completionInfo	55ms (± 0.81%)	61ms (± 6.60%)	+5ms (+ 9.78%)	54ms	67ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	1,603ms (± 0.71%)	1,602ms (± 0.35%)	-1ms (- 0.09%)	1,589ms	1,613ms
Req 2 - geterr	2,337ms (± 0.58%)	2,352ms (± 0.69%)	+15ms (+ 0.64%)	2,318ms	2,384ms
Req 3 - references	284ms (± 0.42%)	285ms (± 0.57%)	+1ms (+ 0.39%)	282ms	289ms
Req 4 - navto	230ms (± 1.82%)	231ms (± 1.70%)	+2ms (+ 0.65%)	227ms	242ms
Req 5 - completionInfo count	1,517 (± 0.00%)	1,517 (± 0.00%)	0 ( 0.00%)	1,517	1,517
Req 5 - completionInfo	53ms (± 0.69%)	53ms (± 0.71%)	-0ms (- 0.19%)	52ms	53ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	2,226ms (± 0.47%)	2,217ms (± 0.54%)	-9ms (- 0.40%)	2,198ms	2,250ms
Req 2 - geterr	780ms (± 0.58%)	777ms (± 0.45%)	-4ms (- 0.45%)	772ms	786ms
Req 3 - references	65ms (± 0.89%)	65ms (± 1.08%)	+0ms (+ 0.15%)	64ms	66ms
Req 4 - navto	247ms (± 0.57%)	248ms (± 0.52%)	+1ms (+ 0.40%)	245ms	251ms
Req 5 - completionInfo count	3,345 (± 0.00%)	3,345 (± 0.00%)	0 ( 0.00%)	3,345	3,345
Req 5 - completionInfo	277ms (± 0.33%)	276ms (± 0.68%)	-1ms (- 0.47%)	273ms	281ms

System

Machine Name	ts-ci-ubuntu
Platform	linux 4.4.0-210-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v10.16.3, x64)
• node (v12.1.0, x64)
• node (v14.15.1, x64)

Scenarios

• Compiler-UnionsTSServer - node (v10.16.3, x64)
• Compiler-UnionsTSServer - node (v12.1.0, x64)
• Compiler-UnionsTSServer - node (v14.15.1, x64)
• CompilerTSServer - node (v10.16.3, x64)
• CompilerTSServer - node (v12.1.0, x64)
• CompilerTSServer - node (v14.15.1, x64)
• xstateTSServer - node (v10.16.3, x64)
• xstateTSServer - node (v12.1.0, x64)
• xstateTSServer - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	50344	10
Baseline	main	10

Developer Information:

Download Benchmark

[DanielRosenwasser]

The perf improvements don't really make sense to me.

@typescript-bot perf test faster

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at b4e02ab. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..50344

Metric	main	50344	Delta	Best	Worst
Angular - node (v14.15.1, x64)
Memory used	337,755k (± 0.01%)	337,776k (± 0.01%)	+21k (+ 0.01%)	337,727k	337,817k
Parse Time	2.08s (± 1.13%)	2.08s (± 1.06%)	+0.01s (+ 0.29%)	2.05s	2.14s
Bind Time	0.90s (± 0.58%)	0.90s (± 0.44%)	-0.00s (- 0.00%)	0.89s	0.91s
Check Time	5.82s (± 0.52%)	5.83s (± 0.63%)	+0.00s (+ 0.00%)	5.76s	5.92s
Emit Time	6.15s (± 1.33%)	6.14s (± 0.64%)	-0.01s (- 0.15%)	6.03s	6.23s
Total Time	14.95s (± 0.68%)	14.95s (± 0.48%)	-0.00s (- 0.01%)	14.77s	15.08s
Compiler-Unions - node (v14.15.1, x64)
Memory used	192,012k (± 0.02%)	192,012k (± 0.02%)	+0k (+ 0.00%)	191,946k	192,162k
Parse Time	0.85s (± 0.56%)	0.85s (± 0.76%)	+0.00s (+ 0.59%)	0.84s	0.87s
Bind Time	0.58s (± 1.28%)	0.58s (± 0.69%)	-0.00s (- 0.17%)	0.57s	0.59s
Check Time	6.95s (± 0.35%)	6.92s (± 0.49%)	-0.04s (- 0.56%)	6.84s	7.01s
Emit Time	2.42s (± 0.82%)	2.41s (± 0.74%)	-0.01s (- 0.50%)	2.37s	2.44s
Total Time	10.80s (± 0.38%)	10.76s (± 0.34%)	-0.05s (- 0.45%)	10.69s	10.86s
Monaco - node (v14.15.1, x64)
Memory used	325,896k (± 0.01%)	325,925k (± 0.01%)	+30k (+ 0.01%)	325,884k	325,953k
Parse Time	1.57s (± 0.61%)	1.58s (± 0.77%)	+0.00s (+ 0.25%)	1.55s	1.60s
Bind Time	0.78s (± 0.71%)	0.78s (± 0.51%)	+0.00s (+ 0.13%)	0.77s	0.79s
Check Time	5.68s (± 0.37%)	5.69s (± 0.61%)	+0.01s (+ 0.11%)	5.60s	5.75s
Emit Time	3.31s (± 0.44%)	3.34s (± 0.80%)	+0.03s (+ 0.81%)	3.29s	3.40s
Total Time	11.34s (± 0.23%)	11.38s (± 0.35%)	+0.04s (+ 0.34%)	11.29s	11.46s
TFS - node (v14.15.1, x64)
Memory used	288,951k (± 0.01%)	288,985k (± 0.01%)	+34k (+ 0.01%)	288,924k	289,032k
Parse Time	1.32s (± 1.02%)	1.35s (± 1.92%)	+0.04s (+ 2.81%)	1.30s	1.44s
Bind Time	0.80s (± 5.15%)	0.74s (± 2.18%)	🟩-0.06s (- 7.62%)	0.72s	0.80s
Check Time	5.36s (± 0.36%)	5.36s (± 0.33%)	-0.00s (- 0.02%)	5.32s	5.39s
Emit Time	3.46s (± 2.36%)	3.57s (± 1.50%)	+0.11s (+ 3.06%)	3.39s	3.63s
Total Time	10.94s (± 0.93%)	11.02s (± 0.61%)	+0.08s (+ 0.72%)	10.80s	11.12s
material-ui - node (v14.15.1, x64)
Memory used	450,208k (± 0.01%)	450,217k (± 0.00%)	+9k (+ 0.00%)	450,170k	450,250k
Parse Time	1.88s (± 0.46%)	1.87s (± 0.64%)	-0.00s (- 0.21%)	1.85s	1.90s
Bind Time	0.71s (± 0.69%)	0.71s (± 0.81%)	-0.00s (- 0.56%)	0.69s	0.72s
Check Time	13.11s (± 0.42%)	13.13s (± 0.65%)	+0.02s (+ 0.11%)	12.93s	13.29s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	15.71s (± 0.37%)	15.72s (± 0.50%)	+0.01s (+ 0.06%)	15.54s	15.85s
xstate - node (v14.15.1, x64)
Memory used	545,806k (± 0.00%)	545,811k (± 0.00%)	+5k (+ 0.00%)	545,790k	545,880k
Parse Time	2.61s (± 0.29%)	2.60s (± 0.60%)	-0.00s (- 0.12%)	2.58s	2.65s
Bind Time	1.14s (± 0.76%)	1.13s (± 0.51%)	-0.01s (- 0.44%)	1.12s	1.14s
Check Time	1.55s (± 0.45%)	1.55s (± 0.43%)	+0.00s (+ 0.13%)	1.54s	1.57s
Emit Time	0.07s (± 4.92%)	0.07s (± 3.14%)	🟩-0.00s (- 4.05%)	0.07s	0.08s
Total Time	5.37s (± 0.24%)	5.37s (± 0.39%)	-0.01s (- 0.11%)	5.33s	5.41s

System

Machine Name	ts-ci-ubuntu
Platform	linux 4.4.0-210-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v14.15.1, x64)

Scenarios

• Angular - node (v14.15.1, x64)
• Compiler-Unions - node (v14.15.1, x64)
• Monaco - node (v14.15.1, x64)
• TFS - node (v14.15.1, x64)
• material-ui - node (v14.15.1, x64)
• xstate - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	50344	10
Baseline	main	10

Developer Information:

Download Benchmark

[a-tarasyuk]

/cc @weswigham and @ahejlsberg