Enforce keyword order between override and static/async#43660
Merged
Conversation
typescript-bot
added
Author: Team
For Milestone Bug
Member
Author
|
Some tests were already using |
DanielRosenwasser
approved these changes
Apr 13, 2021
Contributor
|
The current check of modifier order is painful. Are there any possible to map modifiers into some priority. And we just check the order of priority value. |
Member
Author
|
I agree @Kingwl, looking at that function, it’s begging to be refactored into something more declarative. Personally I would love to see something like that implemented. |
Member
Member
Contributor
|
Thanks for the heads up @DanielRosenwasser! |
Contributor
Member
Author
|
Yes 🤦 |
Contributor
|
🤦 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The order is
static override async.Fixes #43606