Add hardware breakpoints support -- unbind on disable - #1128
Merged
Andrew Wang (WardenGnaw) merged 8 commits intoApr 29, 2021
Conversation
Andrew Wang (WardenGnaw)
requested review from
Andrew Wang (WardenGnaw) and
Gregg Miskelly (gregg-miskelly)
and removed request for
Gregg Miskelly (gregg-miskelly)
April 13, 2021 20:23
Gregg Miskelly (gregg-miskelly)
requested changes
Apr 13, 2021
Gregg Miskelly (gregg-miskelly)
left a comment
Gregg Miskelly (gregg-miskelly)
left a comment
Member
There was a problem hiding this comment.
Otherwise LGTM
Failing to do this, the breakpoint will never be removed if disabled from run mode.
If the breakpoint is disabled, we should not request it from GDB
Gregg Miskelly (gregg-miskelly)
approved these changes
Apr 14, 2021
Andrew Wang (WardenGnaw)
approved these changes
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supercedes the abandoned PR #1123. It has the same goal, but improves the experience by ensuring that error messages propagate to the UI in VS on enable/disable by unbinding breakpoints on disable.
GIF of behavior in VS 2019:
