Add stopAtConnect option and improve entrypoint breakpoint handling - #1109
Merged
Andrew Wang (WardenGnaw) merged 3 commits intoMar 18, 2021
Merged
Conversation
Member
Author
|
FYI this will have (easily resolved) merge conflicts after #1108 goes in. |
Ben McMorran (benmcmorran)
force-pushed
the
dev/bemcmorr/fix-stopatentry
branch
from
March 11, 2021 19:32
0940a3f to
d00fc34
Compare
Gregg Miskelly (gregg-miskelly)
approved these changes
Mar 11, 2021
Gregg Miskelly (gregg-miskelly)
left a comment
Gregg Miskelly (gregg-miskelly)
left a comment
Member
There was a problem hiding this comment.
Otherwise LGTM
Member
|
Ben McMorran (@benmcmorran) Can you update the description to match what your PR does now? |
Ben McMorran (benmcmorran)
changed the title
Member
Author
|
Updated title and description. |
Hedges (Hedges)
added a commit
to Hedges/MIEngine
that referenced
this pull request
Jul 2, 2021
…oint handling (microsoft#1109)" - SHA-1: 2ae2fe3, 18/03/21 plus a compile fix.
Hedges (Hedges)
added a commit
to Hedges/MIEngine
that referenced
this pull request
Sep 2, 2024
…oint handling (microsoft#1109)" - SHA-1: 2ae2fe3
Hedges (Hedges)
added a commit
to Hedges/MIEngine
that referenced
this pull request
Jul 5, 2026
…oint handling (microsoft#1109)" - SHA-1: 2ae2fe3 (cherry picked from commit 3ecb424)
Hedges (Hedges)
added a commit
to Hedges/MIEngine
that referenced
this pull request
Jul 6, 2026
…oint handling (microsoft#1109)" - SHA-1: 2ae2fe3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running into issues debugging an embedded device with OpenOCD where the
stopAtEntrysetting inlaunch.jsonwas ignored and the debugger always threw an exception with "Unknown breakpoint" when entering main.The problem was that
_callback.OnEntryPoint(thread)wasn't called after settingEntrypointHit, so none of thestopAtEntrylogic in OpenDebugAD7 had a chance to run, and that the entrypoint breakpoint inserted onmainby MIEngine was never removed bythis.OnEntrypointHit(). However, even with that added, there was another problem becauseCmdContinueAsync()runs unconditionally.The fix adds a new option,
stopAtConnectthat will always treat unexpected stopped events when connecting as if an entrypoint has been hit and stop. The fix also makes sure that the entrypoint breakpoint inserted onmainis always cleaned up to avoid "Unknown breakpoint" exceptions.With these changes, an embedded device debugging session will correctly respond to
stopAtEntryandstopAtConnect, and will no longer throw spurious exceptions.cc Alan Leung (@aleun)