[Subcontracting] Create TO to Subcontractor honors reduced open WIP line (Bug 639382)#8854
Open
ChethanT wants to merge 4 commits into
Open
[Subcontracting] Create TO to Subcontractor honors reduced open WIP line (Bug 639382)#8854ChethanT wants to merge 4 commits into
ChethanT wants to merge 4 commits into
Conversation
CheckCreateWIPTransfer used an IsEmpty short-circuit that returned false whenever any open WIP transfer line existed, so reducing an unposted line and re-running errored. Now sums posted + open WIP qty and creates the remainder. Added regression test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Copilot PR ReviewIteration 3 · Outcome: completed Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630 Orchestrator pre-filter (13 file(s) excluded)
Findings produced by the Copilot CLI agent against BCQuality at |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
AleksandricMarko
previously approved these changes
Jun 29, 2026
attilatoury
previously approved these changes
Jun 29, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1d77245
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ADO bug 639382.
Problem
'Create Transfer Order to Subcontractor' failed with Nothing to create. No components or WIP to transfer after a WIP transfer line was reduced (e.g. qty 5 -> 3), instead of creating the remaining qty 2.
Root cause
CheckCreateWIPTransfer had an early IsEmpty() short-circuit: if any open WIP transfer line existed it returned false. Coverage was measured only against posted WIP ledger entries, never against open transfer-line quantities, so a reduced (not deleted) line blocked all further creation.
Fix
Test
WIPTransferRemainderCreatedWhenOpenLineQuantityReduced reproduces the scenario.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Fixes AB#639382