[TEST – DO NOT MERGE] Validate BCQuality suggested inline fixes (re-test of #8772) by JesperSchulz · Pull Request #8816 · microsoft/BCApps

JesperSchulz · 2026-06-25T09:45:15Z

⚠️ THIS IS A TEST PR — DO NOT MERGE

This PR exists solely to re-validate the BCQuality Copilot PR-review wiring, specifically that the review agent's suggested inline fixes (GitHub ```suggestion blocks) now render and can be committed with one click.

Why a re-test?

In the first test PR (#8772) the BCQuality review agent posted review comments, but its suggested fixes did not work as one-click GitHub suggestions. A fix has since been deployed, and this PR re-runs the exact byte-identical sample diff from #8772 so we have an apples-to-apples comparison.

Replicates commit c55acc52c605692141ccbd9a8ab3d24ace1b4771 from [TEST – DO NOT MERGE] Validate BCQuality Copilot PR-review wiring #8772.
350 insertions, 0 deletions across 5 files under src/Apps/W1/Quality Management/app/.
Source sample: microsoft/BCAppsBCQuality#47.

Intentional reviewable issues

The sample code is deliberately crafted with issues so the review agent has clear things to flag and attach suggestion blocks to: magic number 500, Commit() inside loops, GET inside loop, discarded Count()/FindFirst() results, PII fields without DataClassification, plain-text credentials, uppercase reserved keywords, spaces before parentheses, an off-by-one loop, and PII in telemetry.

What we are verifying

✅ Review comments render.
✅ Suggested inline fixes (```suggestion blocks) render and are committable with one click (the part that failed in [TEST – DO NOT MERGE] Validate BCQuality Copilot PR-review wiring #8772).

References: #8772, microsoft/BCAppsBCQuality#47

Again: this is a throwaway test PR and must NOT be merged or marked ready for review.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Replicates the byte-identical sample diff from #8772 / microsoft/BCAppsBCQuality#47 to confirm that the BCQuality review agent's suggested inline fixes (```suggestion blocks) now render and are committable. In #8772 the agent's review comments did not work as one-click GitHub suggestions; a fix has since been deployed and this PR re-tests it with an apples-to-apples, byte-identical diff (350 insertions, 0 deletions across 5 files). The sample code intentionally contains reviewable issues (magic number 500, Commit() inside loops, GET inside loop, discarded Count()/FindFirst() results, PII fields without DataClassification, plain-text credentials, uppercase reserved keywords, spaces before parentheses, off-by-one loop, PII in telemetry) so the review agent has clear things to flag and attach suggestion blocks to. This is a throwaway TEST branch and is NOT meant to be merged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-06-25T09:46:24Z

Could not find a linked ADO work item. Please link one by using the pattern 'AB#' followed by the relevant work item number. You may use the 'Fixes' keyword to automatically resolve the work item when the pull request is merged. E.g. 'Fixes AB#1234'

github-actions · 2026-06-25T10:09:10Z

+            if not PromptAndImportIntoInStream(FilterString, FileInStream, ServerFileName) then
+                exit(ImportedCount);
+
+            TempBlob.CreateInStream(FileInStream);


$\textbf{🟡\ Medium\ Severity\ —\ Agent} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

In ImportBatch, TempBlob.CreateInStream(FileInStream) is called on a freshly-initialised, empty Temp Blob (line 55).

This replaces FileInStream — which at this point holds the file content returned by PromptAndImportIntoInStream — with an empty stream derived from the empty blob. The uploaded file data is silently discarded; the procedure then increments the counter and calls Commit() around an empty operation, returning an inaccurate count of successfully imported files. This is a material correctness defect. If buffering in a TempBlob is required, first copy the stream via TempBlob.CreateOutStream and CopyStream, then call TempBlob.CreateInStream. If no buffering is needed, remove the TempBlob.CreateInStream call entirely and consume FileInStream directly. Note that this concern is non-gating as an agent finding; it warrants promotion to a knowledge-backed rule before it can gate a build.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:12Z

+        if ResultBuffer.FindSet() then
+            repeat
+                // GET inside the loop re-reads the same customer on every iteration.
+                Customer.Get(CustomerNo);


$\textbf{🟠\ High\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Customer.Get(CustomerNo) is called inside the repeat…until loop in ImportResults, issuing one database round-trip against the Customer table per result buffer entry.

Because the same CustomerNo is passed on every iteration, this is N identical reads of the same production-scale table row. Lift Customer.Get(CustomerNo) before the FindSet call; a single Get before the loop is sufficient.

Knowledge:

microsoft/knowledge/performance/avoid-get-inside-loop-on-large-table.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:14Z

+                ImportLogEntry.Insert();
+
+                // Commit inside the loop defeats the implicit transaction boundary.
+                Commit();


$\textbf{🟠\ High\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Commit() is called inside a repeat…until loop in ImportResults.

Each row iteration starts a new write transaction, preventing atomic rollback of the whole import operation. If a later ImportLogEntry.Insert() fails, the already-committed rows cannot be unwound. Per the referenced guidance, move the commit to a clearly-defined safe boundary outside the loop, or use bounded checkpoints that each process N rows.

Knowledge:

microsoft/knowledge/performance/avoid-commit-inside-loops.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:15Z

+            ImportedCount += 1;
+
+            // Commit after every imported file, inside the loop.
+            Commit();


$\textbf{🟠\ High\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Commit() is called inside a for loop in ImportBatch, issuing one Commit per file iteration.

The referenced guidance flags Commit inside any per-item loop as almost always a mistake. Remove Commit() from inside the loop; the implicit commit at successful procedure exit is sufficient unless an explicit checkpoint strategy is required.

Knowledge:

microsoft/knowledge/performance/avoid-commit-inside-loops.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:16Z

+    begin
+        ImportLogEntry.SetRange("Customer No.", CustomerNo);
+        // Count() materializes a number the caller does not need.
+        if ImportLogEntry.Count() > 0 then


$\textbf{🟡\ Medium\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

HasImportedResults uses Count() > 0 to test for existence (line 74), then immediately calls FindFirst() as a second existence check (line 77).

Both are the anti-patterns flagged by the referenced guidance: Count() materialises a full count the caller discards, and FindFirst() materialises a row the caller discards. Additionally, because Count() = 0 implies no rows, the FindFirst() branch (line 77) is unreachable. Replace both checks with a single not ImportLogEntry.IsEmpty().

Suggested change

if ImportLogEntry.Count() > 0 then

exit(not ImportLogEntry.IsEmpty());

Knowledge:

microsoft/knowledge/performance/use-isempty-for-existence-check.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

This doesn't look right. It should have suggested to replace both line 74 and 75 with the new suggestion, which now is a one-liner.

github-actions · 2026-06-25T10:09:19Z

+    begin
+        // PII (customer name) placed directly in the telemetry message string,
+        // and a placeholder event id that was never registered.
+        Session.LogMessage(


$\textbf{🟠\ High\ Severity\ —\ Privacy} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Session.LogMessage is called with StrSubstNo('Imported results for customer %1', Customer.Name) as the message argument (line 143).

Customer.Name is a personal name (CustomerContent) and is baked into the plain-text message string before Session.LogMessage runs. The DataClassification argument on the call does not protect the message text; the platform ships whatever is in that string verbatim to telemetry. Per the referenced guidance, the message must be a static non-personal string; move structured context to CustomDimensions. Note: the event ID '0000' is also a placeholder and should be replaced with a registered telemetry event ID.

Knowledge:

microsoft/knowledge/privacy/no-pii-in-telemetry-message-string.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:20Z

+            TelemetryScope::All,
+            'Category', 'QualityImport');
+
+        Dimensions.Add('CustomerName', Customer.Name);


$\textbf{🟠\ High\ Severity\ —\ Privacy} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Dimensions.Add('CustomerName', Customer.Name) places the customer's personal name — CustomerContent / EUII — directly into the FeatureTelemetry CustomDimensions dictionary.

Per the referenced guidance, CustomDimensions values are sent to telemetry as-is with no platform classification applied. Remove Customer.Name from the dictionary and replace with a non-personal signal (for example, a count or a status enum) to preserve the telemetry's usefulness without exposing PII.

Knowledge:

microsoft/knowledge/privacy/featuretelemetry-customdimensions-no-pii.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:22Z

+        field(3; "Customer Name"; Text[100])
+        {
+            Caption = 'Customer Name';
+        }


$\textbf{🟠\ High\ Severity\ —\ Privacy} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Field 'Customer Name' (Text[100]) stores a customer's personal name and has no DataClassification property.

Omitting DataClassification defaults to ToBeClassified, which tells the platform the data has not been reviewed. For a field storing a personal name, DataClassification = CustomerContent is required so GDPR data-subject requests, telemetry, and audit surfaces treat the field correctly.

Suggested change

field(3; "Customer Name"; Text[100])

{

Caption = 'Customer Name';

}

field(3; "Customer Name"; Text[100])

{

Caption = 'Customer Name';

DataClassification = CustomerContent;

}

Knowledge:

microsoft/knowledge/privacy/data-classification-required-on-pii-fields.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:23Z

+        field(4; "Contact Email"; Text[80])
+        {
+            Caption = 'Contact Email';
+        }


$\textbf{🟠\ High\ Severity\ —\ Privacy} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Field 'Contact Email' (Text[80]) stores an email address and has no DataClassification property.

An email address is EndUserIdentifiableInformation or CustomerContent (depending on whether it belongs to the tenant's end-user or their customer). Either way DataClassification must be set explicitly. Omitting it leaves the field as ToBeClassified and prevents the platform from correctly handling GDPR requests and telemetry classification.

Suggested change

field(4; "Contact Email"; Text[80])

{

Caption = 'Contact Email';

}

field(4; "Contact Email"; Text[80])

{

Caption = 'Contact Email';

DataClassification = CustomerContent;

}

Knowledge:

microsoft/knowledge/privacy/data-classification-required-on-pii-fields.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:25Z

+    /// subscribers can override them.
+    /// </summary>
+    [IntegrationEvent(false, false)]
+    procedure OnBeforeCallLabApi(Endpoint: Text; ApiKey: Text; var BearerToken: Text)


$\textbf{🟠\ High\ Severity\ —\ Security} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

OnBeforeCallLabApi exposes ApiKey (Text) and BearerToken (var Text) as integration event parameters.

Any extension on the tenant can subscribe to this event and read or overwrite both credentials with no permission check. Per the referenced guidance, authentication is handled by the publisher — credentials must never appear in an event signature. Remove ApiKey and BearerToken from the event parameters; the publisher should apply credentials internally before or after raising the event.

Knowledge:

microsoft/knowledge/security/integrationevent-must-not-expose-secrets.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:26Z

+
+    local procedure FetchResultsIntoBuffer(CustomerNo: Code[20]; var ResultBuffer: Record "Qlty. Import Log Entry" temporary)
+    var
+        ApiKey: Text;


$\textbf{🟠\ High\ Severity\ —\ Security} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

ApiKey and BearerToken are declared as Text in FetchResultsIntoBuffer (lines 84–85) and passed through DownloadResults as Text parameters (line 97).

The referenced guidance requires credential-carrying variables to be SecretText end-to-end so the compiler prevents accidental plain-text exposure and the debugger cannot read them. Change the type of ApiKey and BearerToken to SecretText in both the local variable declarations and the DownloadResults signature, and update GetApiKey() / GetAccessToken() to return SecretText.

Knowledge:

microsoft/knowledge/security/secrettext-for-credentials.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:28Z

+    begin
+        // Error message composed with StrSubstNo instead of passing the
+        // parameter directly to Error().
+        Error(StrSubstNo('Could not import results for customer %1', CustomerNo));


$\textbf{🟠\ High\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

RaiseImportError calls Error(StrSubstNo('Could not import results for customer %1', CustomerNo)).

StrSubstNo appearing as a direct argument to Error() is the anti-pattern the referenced guidance flags unconditionally: it hides the format-string identity from analyzers, breaks the translation pipeline's ability to link the call to its label, and removes the platform's ability to classify substituted parameters individually. Declare a Label with an Err suffix and a Comment for the placeholder, then call Error(YourErr, CustomerNo). Note also that the format string is a hardcoded literal rather than a Label, which prevents translation.

Knowledge:

microsoft/knowledge/style/error-passes-parameters-directly-not-strsubstno.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:29Z

+    VAR
+        ValidCount: Integer;
+    BEGIN
+        IF ImportLogEntry.FindSet() THEN
+            REPEAT
+                IF ImportLogEntry."Result Value" > 0 THEN
+                    ValidCount += 1;
+            UNTIL ImportLogEntry.Next() = 0;
+        EXIT(ValidCount);
+    END;


$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

The entire body of CountValidEntries (lines 113–122) uses uppercase reserved keywords: VAR, BEGIN, IF, THEN, REPEAT, UNTIL, EXIT.

CodeCop AA0241 requires keywords to be lowercase in new AL code. The standard AL formatter normalises casing automatically; applying it to this procedure body resolves all instances.

Suggested change

VAR

ValidCount: Integer;

BEGIN

IF ImportLogEntry.FindSet() THEN

REPEAT

IF ImportLogEntry."Result Value" > 0 THEN

ValidCount += 1;

UNTIL ImportLogEntry.Next() = 0;

EXIT(ValidCount);

END;

var

ValidCount: Integer;

begin

if ImportLogEntry.FindSet() then

repeat

if ImportLogEntry."Result Value" > 0 then

ValidCount += 1;

until ImportLogEntry.Next() = 0;

exit(ValidCount);

end;

Knowledge:

microsoft/knowledge/style/lowercase-reserved-keywords.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:31Z

+        if ImportLogEntry.Get (EntryNo) then
+            exit (ImportLogEntry."Customer Name");
+        exit ('');


$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

DescribeEntry contains three calls with a space before the opening parenthesis: 'ImportLogEntry.Get (EntryNo)' (line 129), 'exit (ImportLogEntry."Customer Name")' (line 130), and 'exit ('')' (line 131).

CodeCop AA0002 forbids whitespace between a name and its opening parenthesis. The standard AL formatter removes these spaces automatically.

Suggested change

if ImportLogEntry.Get (EntryNo) then

exit (ImportLogEntry."Customer Name");

exit ('');

if ImportLogEntry.Get(EntryNo) then

exit(ImportLogEntry."Customer Name");

exit('');

Knowledge:

microsoft/knowledge/style/no-space-before-method-parenthesis.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:32Z

+                field("Customer No."; Rec."Customer No.")
+                {
+                }


$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Field 'Customer No.' on page 'Qlty.

Import Log' has no ToolTip property. CodeCop AA0218 requires a non-empty ToolTip on every page field control. Missing tooltips suppress the hover text and screen-reader announcement for this field.

Suggested change

field("Customer No."; Rec."Customer No.")

{

}

field("Customer No."; Rec."Customer No.")

{

ToolTip = 'Specifies the customer number for the import log entry.';

}

Knowledge:

microsoft/knowledge/style/tooltip-required-on-page-fields.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:34Z

+                field("Customer Name"; Rec."Customer Name")
+                {
+                }


$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Field 'Customer Name' on page 'Qlty.

Import Log' has no ToolTip property. CodeCop AA0218 requires a non-empty ToolTip on every page field control.

Suggested change

field("Customer Name"; Rec."Customer Name")

{

}

field("Customer Name"; Rec."Customer Name")

{

ToolTip = 'Specifies the name of the customer for the import log entry.';

}

Knowledge:

microsoft/knowledge/style/tooltip-required-on-page-fields.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:36Z

+                field("Contact Email"; Rec."Contact Email")
+                {
+                }


$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Field 'Contact Email' on page 'Qlty.

Import Log' has no ToolTip property. CodeCop AA0218 requires a non-empty ToolTip on every page field control.

Suggested change

field("Contact Email"; Rec."Contact Email")

{

}

field("Contact Email"; Rec."Contact Email")

{

ToolTip = 'Specifies the contact email address for the import log entry.';

}

Knowledge:

microsoft/knowledge/style/tooltip-required-on-page-fields.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:37Z

+                field("Imported At"; Rec."Imported At")
+                {
+                }


$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Field 'Imported At' on page 'Qlty.

Import Log' has no ToolTip property. CodeCop AA0218 requires a non-empty ToolTip on every page field control.

Suggested change

field("Imported At"; Rec."Imported At")

{

}

field("Imported At"; Rec."Imported At")

{

ToolTip = 'Specifies the date and time when the results were imported.';

}

Knowledge:

microsoft/knowledge/style/tooltip-required-on-page-fields.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:39Z

+    /// </summary>
+    procedure GetDialogTitle(): Text
+    begin
+        exit (ImportFromLbl);


$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

GetDialogTitle contains 'exit (ImportFromLbl)' with a space before the opening parenthesis (line 70).

CodeCop AA0002 forbids whitespace between a name and its opening parenthesis.

Suggested change

exit (ImportFromLbl);

exit(ImportFromLbl);

Knowledge:

microsoft/knowledge/style/no-space-before-method-parenthesis.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

github-actions · 2026-06-25T10:09:42Z

Copilot PR Review

Iteration 1 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain	Findings	Knowledge-backed	Agent	Inline
Agent	1	0	1	1
Performance	4	4	0	4
Privacy	4	4	0	4
Security	2	2	0	2
Style	8	8	0	8

Totals: 18 knowledge-backed · 1 agent findings.

Orchestrator pre-filter (13 file(s) excluded)

layer-disabled (knowledge) : 13 file(s)

_{Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.}

github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Jun 25, 2026

JesperSchulz marked this pull request as ready for review June 25, 2026 09:47

JesperSchulz requested a review from a team June 25, 2026 09:47

github-actions Bot reviewed Jun 25, 2026

View reviewed changes

JesperSchulz closed this Jun 25, 2026

JesperSchulz mentioned this pull request Jun 25, 2026

[TEST – DO NOT MERGE] Loyalty Sample across all 11 BCQuality domains #8822

Open

	if ImportLogEntry.Count() > 0 then
	exit(not ImportLogEntry.IsEmpty());

Uh oh!

Conversation

JesperSchulz commented Jun 25, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ THIS IS A TEST PR — DO NOT MERGE

Why a re-test?

Intentional reviewable issues

What we are verifying

Uh oh!

github-actions Bot commented Jun 25, 2026

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

In ImportBatch, TempBlob.CreateInStream(FileInStream) is called on a freshly-initialised, empty Temp Blob (line 55).

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

Customer.Get(CustomerNo) is called inside the repeat…until loop in ImportResults, issuing one database round-trip against the Customer table per result buffer entry.

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

Commit() is called inside a repeat…until loop in ImportResults.

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

Commit() is called inside a for loop in ImportBatch, issuing one Commit per file iteration.

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

HasImportedResults uses Count() > 0 to test for existence (line 74), then immediately calls FindFirst() as a second existence check (line 77).

Uh oh!

JesperSchulz Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

Session.LogMessage is called with StrSubstNo('Imported results for customer %1', Customer.Name) as the message argument (line 143).

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

Dimensions.Add('CustomerName', Customer.Name) places the customer's personal name — CustomerContent / EUII — directly into the FeatureTelemetry CustomDimensions dictionary.

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

Field 'Customer Name' (Text[100]) stores a customer's personal name and has no DataClassification property.

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

Field 'Contact Email' (Text[80]) stores an email address and has no DataClassification property.

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

OnBeforeCallLabApi exposes ApiKey (Text) and BearerToken (var Text) as integration event parameters.

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

ApiKey and BearerToken are declared as Text in FetchResultsIntoBuffer (lines 84–85) and passed through DownloadResults as Text parameters (line 97).

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

RaiseImportError calls Error(StrSubstNo('Could not import results for customer %1', CustomerNo)).

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

The entire body of CountValidEntries (lines 113–122) uses uppercase reserved keywords: VAR, BEGIN, IF, THEN, REPEAT, UNTIL, EXIT.

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

DescribeEntry contains three calls with a space before the opening parenthesis: 'ImportLogEntry.Get (EntryNo)' (line 129), 'exit (ImportLogEntry."Customer Name")' (line 130), and 'exit ('')' (line 131).

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

Field 'Customer No.' on page 'Qlty.

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

Field 'Customer Name' on page 'Qlty.

Uh oh!

github-actions Bot Jun 25, 2026

Choose a reason for hiding this comment

JesperSchulz commented Jun 25, 2026 •

edited by github-actions Bot

Loading