scan: report isGlobstar without scanToEnd - #204
Open
lenamonj wants to merge 1 commit into
Open
Conversation
Without scanToEnd the scan loop stops at the first star, and isGlobstar was
only ever set from the second one, so scan('**').isGlobstar was false while
scan('**', { scanToEnd: true }).isGlobstar was true. Look ahead as well as
behind.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
picomatch.scan('**').isGlobstarisfalse, and so isscan('foo/**/*.js').isGlobstar; the same inputs with{ scanToEnd: true }reporttrue.Cause: without
scanToEndthe loop finishes at the first*, andisGlobstarwas only set when the previous character was a star, so it could only ever be seen from the second one.Change: also check
peek()for the next character. One line, plus a test for the default-options path (the existing globstar tests all passscanToEnd: true).Verified:
npm test1999 passing (the new test fails onmaster).Found by an automated code-review loop I run; the fix and this description were prepared with Claude and verified by hand.