Request failed: 401 - Unauthorized - Couldn't authenticate you

[gy-mate]

Hallo Stefan!

I'm trying to use osmapi 4.3.0 in a Briefcase 0.3.22 and Toga 0.5.0 app on macOS 15.4. The relevant code looks like this:

    api = osmapi.OsmApi(
        api='https://master.apis.dev.openstreetmap.org',
        username="my correct https://master.apis.dev.openstreetmap.org username",
        password="my correct https://master.apis.dev.openstreetmap.org password"
    )
    api.ChangesetCreate(
        ChangesetTags={
            'created_by': 'Surveyor 0.0.1',
            'comment': 'Add new node through the dev API_001',
        }
    )

But api.ChangesetCreate() gives me the following error:

ApiError Exception occured
Traceback (most recent call last):
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Resources/app_packages/osmapi/http.py", line 111, in _http
    return self._http_request(
           ~~~~~~~~~~~~~~~~~~^
        cmd, path, auth, send, return_value=return_value
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Resources/app_packages/osmapi/http.py", line 88, in _http_request
    raise errors.UnauthorizedApiError(
        response.status_code, response.reason, payload
    )
osmapi.errors.UnauthorizedApiError: Request failed: 401 - Unauthorized - b"Couldn't authenticate you"
Error in async handler: Request failed: 401 - Unauthorized - b"Couldn't authenticate you"
Traceback (most recent call last):
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Resources/app_packages/toga/handlers.py", line 94, in handler_with_cleanup
    result = await handler(interface, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Resources/app/surveyor/app.py", line 147, in take_photo
    await upload_to_osm(tags)
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Resources/app/surveyor/app.py", line 45, in upload_to_osm
    api.ChangesetCreate(
    ~~~~~~~~~~~~~~~~~~~^
        ChangesetTags={
        ^^^^^^^^^^^^^^^
    ...<2 lines>...
        }
        ^
    )
    ^
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Resources/app_packages/osmapi/OsmApi.py", line 1303, in ChangesetCreate
    result = self._session._put(
        "/api/0.6/changeset/create",
        xmlbuilder._XmlBuild("changeset", {"tag": ChangesetTags}, data=self),
    )
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Resources/app_packages/osmapi/http.py", line 158, in _put
    return self._http("PUT", path, True, data, return_value=return_value)
           ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Resources/app_packages/osmapi/http.py", line 111, in _http
    return self._http_request(
           ~~~~~~~~~~~~~~~~~~^
        cmd, path, auth, send, return_value=return_value
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Resources/app_packages/osmapi/http.py", line 88, in _http_request
    raise errors.UnauthorizedApiError(
        response.status_code, response.reason, payload
    )
osmapi.errors.UnauthorizedApiError: Request failed: 401 - Unauthorized - b"Couldn't authenticate you"

Do you know what could have caused the error? Is it maybe an HTTPS issue? (The .app in which the code is run is signed with an ad-hoc certificate.)

Many thanks for your help in advance!

[metaodi]

This is because the username/password authentication has been deprecated, see the README and the OAuth alternative: https://github.com/metaodi/osmapi?tab=readme-ov-file#oauth-authentication

[gy-mate]

Thanks a lot! I've replaced the username and password parameters with passing a requests.sessions.Session object to session:

    api = osmapi.OsmApi(
        api="https://master.apis.dev.openstreetmap.org",
        session=session
    )
    
    with api.Changeset({
        'created_by': 'Columbus 0.0.1',
        'comment': 'Add new node through the dev API_001',
    }):
        api.NodeCreate({
            'lat': 46.8679445,
            'lon': 20.2073881,
            'tag': tags
        })

But now I get a Username/Password missing error:

Error in async handler: Username/Password missing
Traceback (most recent call last):
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Resources/app_packages/toga/handlers.py", line 94, in handler_with_cleanup
    result = await handler(interface, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Resources/app/surveyor/app.py", line 196, in take_photo
    await upload_to_osm(tags)
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Resources/app/surveyor/app.py", line 95, in upload_to_osm
    with api.Changeset({
         ~~~~~~~~~~~~~^^
        'created_by': 'Columbus 0.0.1',
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        'comment': 'Add new node through the dev API_001',
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    }):
    ^^
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Frameworks/Python.framework/Versions/3.13/lib/python3.13/contextlib.py", line 141, in __enter__
    return next(self.gen)
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Resources/app_packages/osmapi/OsmApi.py", line 1199, in Changeset
    changeset_id = self.ChangesetCreate(ChangesetTags)
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Resources/app_packages/osmapi/OsmApi.py", line 1303, in ChangesetCreate
    result = self._session._put(
        "/api/0.6/changeset/create",
        xmlbuilder._XmlBuild("changeset", {"tag": ChangesetTags}, data=self),
    )
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Resources/app_packages/osmapi/http.py", line 158, in _put
    return self._http("PUT", path, True, data, return_value=return_value)
           ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Resources/app_packages/osmapi/http.py", line 111, in _http
    return self._http_request(
           ~~~~~~~~~~~~~~~~~~^
        cmd, path, auth, send, return_value=return_value
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/Users/.../Desktop/drop/python/surveyor/surveyor/build/surveyor/macos/app/Surveyor.app/Contents/Resources/app_packages/osmapi/http.py", line 70, in _http_request
    raise errors.UsernamePasswordMissingError("Username/Password missing")
osmapi.errors.UsernamePasswordMissingError: Username/Password missing

What could cause this error?

[metaodi]

You need a bit more than the session, here is a complete example: https://github.com/metaodi/osmapi/blob/develop/examples/oauth2.py

[gy-mate]

Yeah, sorry—I forgot to include those lines in the code snippet. :(

So the full snippet looks like this:

    # [...]
    # access_token acquired automatically using authlib.integrations.requests_client.oauth2_session.OAuth2Session
    # and wsgiref.simple_server

    session = Session()
    session.headers.update({
        'Authorization': f'Bearer {access_token}',
    })

    api = osmapi.OsmApi(
        api="https://master.apis.dev.openstreetmap.org",
        session=session
    )
    
    with api.Changeset({
        'created_by': 'Columbus 0.0.1',
        'comment': 'Add new node through the dev API_001',
    }):
        api.NodeCreate({
            'lat': 46.8679445,
            'lon': 20.2073881,
            'tag': tags
        })

(Unfortunately I don't have the option to input the authorization code manually as I'm deploying the app on iOS.)

Does wrapping the access_token in a requests_oauth2client.OAuth2AuthorizationCodeAuth() object provide any more functionality than this solution? Couldn't it be done without it?

[metaodi]

I see, maybe have a look at the "backend" example that I provide: https://github.com/metaodi/osmapi/blob/develop/examples/oauth2_backend.py

The idea is to generate a token manually and then save the token to then use in the backend. If it's safe to deploy the token to an iOS app is another question, I'm not sure what the current best practice is.

[gy-mate]

The idea is to generate a token manually and then save the token to then use in the backend.

Thanks! Actually, I’d like to automate the token generation process (like OpenStop does) to make it more user-friendly.