Compat data for import attributes - #20949
Merged
Merged
Conversation
github-actions
Bot
added
the
data:js
nicolo-ribaudo
commented
Oct 12, 2023
nicolo-ribaudo
commented
Oct 12, 2023
Elchi3
reviewed
Oct 17, 2023
Elchi3
left a comment
Elchi3
left a comment
Member
There was a problem hiding this comment.
Thanks for your PR! Two questions for you
queengooborg
requested changes
Nov 7, 2023
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
nicolo-ribaudo
force-pushed
the
import-attributes
branch
from
November 7, 2023 12:19
c6f6f99 to
a86c3ef
Compare
Contributor
Author
|
Thanks for finishing this! |
Elchi3
added a commit
to Elchi3/browser-compat-data
that referenced
this pull request
Nov 14, 2023
* Compat data for import attributes * `npm run fix` * Apply suggestions from code review Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com> * Node.js 21.0.0 supports it * update id --------- Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com> Co-authored-by: Florian Scholz <fs@florianscholz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds compat data for the Stage 3 "import attributes" proposal (https://tc39.es/proposal-import-attributes/).
MDN already has data for the old version of the proposal: I left it there and marked it as deprecated, as the proposal does (https://tc39.es/proposal-import-attributes/#sec-deprecated-assert-keyword-for-import-attributes)
Test results and supporting details
https://deno.com/blog/v1.37
Related issues
mdn/content#29572