Skip to content

Fixnamed options pattern#1116

Merged
rocky merged 12 commits into
masterfrom
fixnamedOptionsPattern
Feb 7, 2021
Merged

Fixnamed options pattern#1116
rocky merged 12 commits into
masterfrom
fixnamedOptionsPattern

Conversation

@mmatera

@mmatera mmatera commented Jan 18, 2021

Copy link
Copy Markdown
Contributor

Improves the support for handling options

@mmatera mmatera requested a review from rocky January 18, 2021 04:27
Comment thread test/test_evaluation.py Outdated
@mmatera

mmatera commented Jan 23, 2021

Copy link
Copy Markdown
Contributor Author

@rocky: I included some of your hits to DRY the tests, and also added some other fixes (in particular, to handle attributes in anonymous functions).

@rocky rocky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocky rocky merged commit 5b8d8be into master Feb 7, 2021
@mmatera mmatera deleted the fixnamedOptionsPattern branch February 7, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants