Fix regex match in test_from_timestamp_with_overflow_value on Windows (fixes #2999) - #3046
Open
eminsk wants to merge 1 commit into
Open
Fix regex match in test_from_timestamp_with_overflow_value on Windows (fixes #2999)#3046eminsk wants to merge 1 commit into
eminsk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (fixes #2999)
On Windows runners and systems,
test_from_timestamp_with_overflow_valuefails with anAssertionErrorbecause the underlying C runtime raises anOSError([Errno 22] Invalid argument) instead of Python'sValueError.marshmallow.utils.from_timestampcatchesOSErrorand wraps it into:Consequently, the exception raised on Windows is
ValueError("Error converting value to datetime"), which did not match the previous patternr"out of range|year must be in 1\.\.9999".Solution
test_from_timestamp_with_overflow_valueregex pattern to also acceptError converting value to datetime(raised from WindowsOSError) andTimestamp is too large(raised fromOverflowError).test_from_timestamp_ms_with_overflow_valueto ensure consistent test coverage for millisecond timestamps across platforms.AUTHORS.rstandCHANGELOG.rst.