chore: update mdk - #735
Merged
Merged
Conversation
WalkthroughChangesMarmotKit update
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/sync-bindings.sh`:
- Line 12: Update the MDK_DIR default in sync-bindings.sh to match the
documented ~/code/mdk location used by AGENTS.md and README.md, preserving the
ability for an explicitly provided MDK_DIR environment variable to override it.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0eddbd22-535a-4f5d-ac85-853fa01c031f
📒 Files selected for processing (7)
Vendored/MarmotKit/MARMOT_VERSIONVendored/MarmotKit/MarmotKit.xcframework/macos-arm64/Headers/marmot_uniffiFFI.hVendored/MarmotKit/MarmotKit.xcframework/macos-arm64/Headers/module.modulemapVendored/MarmotKit/MarmotKit.xcframework/macos-arm64/libmarmot_uniffi.aVendored/MarmotKit/Sources/MarmotKit/MarmotKit.swiftVendored/MarmotKit/Sources/MarmotKit/MarmotKitVersion.swiftscripts/sync-bindings.sh
pepina-dev
force-pushed
the
chore/update-mdk
branch
from
August 7, 2026 15:25
0ce0172 to
0e461f9
Compare
pepina-dev
force-pushed
the
chore/update-mdk
branch
from
August 7, 2026 15:27
0e461f9 to
5ef39e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update mdk to match whitenoise-ios mdk version
Summary by CodeRabbit