Skip to content

chore: update mdk - #735

Merged
pepina-dev merged 2 commits into
masterfrom
chore/update-mdk
Aug 7, 2026
Merged

chore: update mdk#735
pepina-dev merged 2 commits into
masterfrom
chore/update-mdk

Conversation

@pepina-dev

@pepina-dev pepina-dev commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Update mdk to match whitenoise-ios mdk version

Summary by CodeRabbit

  • New Features
    • Added support for recovering incomplete account setup.
    • Added an option to reset incomplete account setup.
  • Improvements
    • Updated the embedded MarmotKit build.
    • Improved compatibility with the MarmotKit native interface.
  • Bug Fixes
    • Corrected expired secure-delete result handling to accurately report completion status.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Changes

MarmotKit update

Layer / File(s) Summary
MarmotKit FFI surface
Vendored/MarmotKit/MarmotKit.xcframework/macos-arm64/Headers/marmot_uniffiFFI.h
The callback-vtable initializer now accepts a const vtable. The header adds incomplete-setup recovery and reset methods with checksum declarations.
Platform module dependencies
Vendored/MarmotKit/MarmotKit.xcframework/macos-arm64/Headers/module.modulemap
The module map declares Darwin and builtin standard C module dependencies.
Build provenance and secure-delete result
Vendored/MarmotKit/MARMOT_VERSION, Vendored/MarmotKit/Sources/MarmotKit/MarmotKitVersion.swift, whitenoise-macTests/whitenoise_macTests.swift
Vendored MDK identifiers and public build provenance constants reference the updated build. The secure-delete result sets erasurePending to false.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating the vendored MDK.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/update-mdk

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/sync-bindings.sh`:
- Line 12: Update the MDK_DIR default in sync-bindings.sh to match the
documented ~/code/mdk location used by AGENTS.md and README.md, preserving the
ability for an explicitly provided MDK_DIR environment variable to override it.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0eddbd22-535a-4f5d-ac85-853fa01c031f

📥 Commits

Reviewing files that changed from the base of the PR and between f95cefa and 0ce0172.

📒 Files selected for processing (7)
  • Vendored/MarmotKit/MARMOT_VERSION
  • Vendored/MarmotKit/MarmotKit.xcframework/macos-arm64/Headers/marmot_uniffiFFI.h
  • Vendored/MarmotKit/MarmotKit.xcframework/macos-arm64/Headers/module.modulemap
  • Vendored/MarmotKit/MarmotKit.xcframework/macos-arm64/libmarmot_uniffi.a
  • Vendored/MarmotKit/Sources/MarmotKit/MarmotKit.swift
  • Vendored/MarmotKit/Sources/MarmotKit/MarmotKitVersion.swift
  • scripts/sync-bindings.sh

Comment thread scripts/sync-bindings.sh Outdated
@pepina-dev
pepina-dev marked this pull request as ready for review August 7, 2026 16:16
@pepina-dev
pepina-dev merged commit dace7b0 into master Aug 7, 2026
3 checks passed
@pepina-dev
pepina-dev deleted the chore/update-mdk branch August 7, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant