Fix <ReferenceFieldBase> does not work offline - #11163
Merged
Merged
Conversation
## Problem ReferenceField hides the (stale) data when the network returns an error. This is not the default behavior of TanStack Query, and this means that ReferenceField will always render empty in offline. ## Solution If the query returns data, even in case of error, return it.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes offline rendering for ReferenceField by ensuring useReference returns cached/placeholder reference data even when the underlying query is in an error state (e.g., network failure while offline), aligning with TanStack Query’s default “keep data on error” behavior.
Changes:
- Update
useReferenceto no longer hidereferenceRecordwhenerroris set. - Preserve stale/cached reference data for offline and refetch-error scenarios.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slax57
approved these changes
Feb 16, 2026
slax57
changed the title
<ReferenceFieldBase> does not work offline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ReferenceField hides the (stale) data when the network returns an error. This is not the default behavior of TanStack Query, and this means that ReferenceField will always render empty in offline.
Solution
If the query returns data, even in case of error, return it.