Skip to content

Make notify_frontend required (no default) in set_ui_element_value#9264

Merged
manzt merged 1 commit intopush-ltuwuvrsukuwfrom
copilot/remove-default-arg
Apr 19, 2026
Merged

Make notify_frontend required (no default) in set_ui_element_value#9264
manzt merged 1 commit intopush-ltuwuvrsukuwfrom
copilot/remove-default-arg

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 19, 2026

The notify_frontend kwarg added to set_ui_element_value had a = False default, leaving call sites implicitly opted out. Making it required forces every caller to be explicit about intent.

Changes

  • Removed = False default from notify_frontend in all four layers of the call chain:
    • Kernel.set_ui_element_value (runtime.py)
    • AppKernelRunner.set_ui_element_value (kernel_runner.py)
    • InternalApp._set_ui_element_value / AppKernelRunner.set_ui_element_value (app.py)
  • Explicitly passed notify_frontend=False at all previously-implicit call sites:
    • handle_set_ui_element_value — user-initiated frontend update
    • handle_receive_model_message — widget comm update
    • All test call sites across test_runtime, test_app, test_cell_runner, test_refresh, test_run_button, test_anywidget
  • _code_mode/_context.py already passes notify_frontend=True explicitly — no change needed

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Apr 19, 2026 0:39am

Request Review

@manzt manzt marked this pull request as ready for review April 19, 2026 12:40
@manzt manzt merged commit 280f788 into push-ltuwuvrsukuw Apr 19, 2026
4 checks passed
@manzt manzt deleted the copilot/remove-default-arg branch April 19, 2026 12:41
@github-actions
Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants