Make notify_frontend required (no default) in set_ui_element_value#9264
Merged
manzt merged 1 commit intopush-ltuwuvrsukuwfrom Apr 19, 2026
Merged
Make notify_frontend required (no default) in set_ui_element_value#9264manzt merged 1 commit intopush-ltuwuvrsukuwfrom
notify_frontend required (no default) in set_ui_element_value#9264manzt merged 1 commit intopush-ltuwuvrsukuwfrom
Conversation
…ll sites Agent-Logs-Url: https://github.com/marimo-team/marimo/sessions/e1c9173c-7a55-42d5-b5f9-3853ee3f7c82 Co-authored-by: manzt <24403730+manzt@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
manzt
April 19, 2026 12:39
View session
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
notify_frontendkwarg added toset_ui_element_valuehad a= Falsedefault, leaving call sites implicitly opted out. Making it required forces every caller to be explicit about intent.Changes
= Falsedefault fromnotify_frontendin all four layers of the call chain:Kernel.set_ui_element_value(runtime.py)AppKernelRunner.set_ui_element_value(kernel_runner.py)InternalApp._set_ui_element_value/AppKernelRunner.set_ui_element_value(app.py)notify_frontend=Falseat all previously-implicit call sites:handle_set_ui_element_value— user-initiated frontend updatehandle_receive_model_message— widget comm updatetest_runtime,test_app,test_cell_runner,test_refresh,test_run_button,test_anywidget_code_mode/_context.pyalready passesnotify_frontend=Trueexplicitly — no change needed