fix(file_browser): Tailwind v4 opacity fix, selection toggle, hover colors, and cleanup#9259
Merged
kirangadhave merged 1 commit intomainfrom Apr 18, 2026
Merged
Conversation
…olors, and cleanup
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
approved these changes
Apr 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes FileBrowser selection/hover UX issues introduced by the Tailwind v4 upgrade, and improves selection toggling behavior for multiple=false.
Changes:
- Replace deprecated Tailwind opacity utilities with
bg-*/NNsyntax and adjust hover/selected row colors. - Fix single-selection toggling so the checkbox can deselect the current selection.
- Refactor checkbox/icon rendering into a small component and avoid mutating the
labelprop.
Comments suppressed due to low confidence (2)
frontend/src/plugins/impl/FileBrowserPlugin.tsx:324
selectAllFiles()currently only skips directories whencanSelectDirectoriesis false, but it never skips regular files whencanSelectFilesis false (e.g.selectionMode === "directory"). This will cause “Select all” to select files even when only directory selection is allowed; add the symmetric!canSelectFiles && !file.is_directoryguard (or reuse theselectablelist).
for (const file of files) {
if (!canSelectDirectories && file.is_directory) {
continue;
}
if (selectedPaths.has(file.path)) {
continue;
}
frontend/src/plugins/impl/FileBrowserPlugin.tsx:330
- In
selectAllFiles(), selection/deduping usesfile.pathdirectly, but row rendering normalizes paths that start with"//"(seefilePath = filePath.slice(1)). If the backend returns"//..."paths, “Select all” can add a differently-normalized path than click-selection, leading to inconsistentselectedPaths.has(...)results and duplicates. Normalizefile.paththe same way inselectAllFiles()before checking/adding.
for (const file of files) {
if (!canSelectDirectories && file.is_directory) {
continue;
}
if (selectedPaths.has(file.path)) {
continue;
}
const fileInfo = createFileInfo({
path: file.path,
name: file.name,
isDirectory: file.is_directory,
});
filesInView.push(fileInfo);
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.2-dev54 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #9157
bg-opacity-*. Replaced with newerbg-primary/25. The fully saturated blue hid the checkboxmultiple=False. The checkbox let you select, but no deselect.hover:bg-accentwhich is more inline with rest of the styleslabelis a prop and was being mutated, fixed thatBefore
Screen.Recording.2026-04-17.at.7.26.25.PM.mov
After
Screen.Recording.2026-04-17.at.7.28.03.PM.mov