fix: use urlparse instead of regex for proxy determination#9254
Merged
fix: use urlparse instead of regex for proxy determination#9254
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes startup crashes when --proxy is provided as a full URL by replacing a brittle proxy host/port regex with urllib.parse.urlparse, ensuring the external-facing host/port are derived correctly for URL generation and display.
Changes:
- Replace regex-based proxy parsing with
urlparse-based parsing in_resolve_proxy. - Add tests covering proxy resolution for bare hostnames, host:port, scheme URLs, and bracketed IPv6.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
marimo/_server/start.py |
Switch proxy host/port determination to urlparse and apply scheme-based default ports (80/443). |
tests/_server/test_startup_url.py |
Add parametrized tests for _resolve_proxy with common proxy formats. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.2-dev69 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
closes #9250
Replaces brittle regex for proxy determination with
urlparse