Skip to content

change wasm link to molab link on run page#9240

Merged
akshayka merged 5 commits intomainfrom
sham/add-molab-open-button
Apr 18, 2026
Merged

change wasm link to molab link on run page#9240
akshayka merged 5 commits intomainfrom
sham/add-molab-open-button

Conversation

@Light2Dark
Copy link
Copy Markdown
Collaborator

@Light2Dark Light2Dark commented Apr 17, 2026 •
edited
Loading

📝 Summary

image

📋 Pre-Review Checklist

  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • Any AI generated code has been reviewed line-by-line by the human PR author, who stands by it.
  • Video or media evidence is provided for any visual changes (optional).

✅ Merge Checklist

  • I have read the contributor guidelines.
  • Documentation has been updated where applicable, including docstrings for API changes.
  • Tests have been added for the changes made.

@Light2Dark Light2Dark requested review from akshayka and Copilot April 17, 2026 08:24
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 17, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Apr 17, 2026 8:40am

Request Review

@Light2Dark Light2Dark added the enhancement New feature or request label Apr 17, 2026
Copilot AI reviewed Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the static notebook “Run or Edit” dialog to direct users to molab (hosted notebooks) instead of the prior WebAssembly link flow, aligning the run-page CTA with the cloud offering.

Changes:

  • Replace the WebAssembly share link with a molab /new share link generated via createShareableLink.
  • Update the dialog UI to present an “Open in molab” button with an icon and refreshed explanatory text.

Comment thread frontend/src/components/static-html/static-banner.tsx Outdated
Comment thread frontend/src/components/static-html/static-banner.tsx
Light2Dark and others added 2 commits April 17, 2026 16:39
@Light2Dark
change to run
5c358b2
@Light2Dark
Apply suggestion from @Copilot
331184d 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@akshayka akshayka merged commit aefb859 into main Apr 18, 2026
31 checks passed
@akshayka akshayka deleted the sham/add-molab-open-button branch April 18, 2026 00:04
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 18, 2026

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.2-dev53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@akshayka akshayka akshayka approved these changes

@mscolnick mscolnick mscolnick approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Light2Dark @akshayka @mscolnick