Add warning log when repr_mimebundle fails#9199
Merged
Light2Dark merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds logging to surface Altair chart rendering issues that were previously silently ignored when _repr_mimebundle_() fails (e.g., missing vl-convert-python or misconfiguration), improving debuggability in the output formatting pipeline.
Changes:
- Log a warning when
chart._repr_mimebundle_()raises an exception during Altair formatting.
| except Exception: | ||
| pass | ||
| except Exception as e: | ||
| LOGGER.warning("Failed to get mimebundle from chart: %s", e) |
Contributor
There was a problem hiding this comment.
traceback might be noisy
Comment on lines
48
to
+52
| mimebundle: MimeBundle | tuple[MimeBundle, MimeBundle] = {} | ||
| try: | ||
| mimebundle = chart._repr_mimebundle_() or {} # type: ignore | ||
| except Exception: | ||
| pass | ||
| except Exception as e: | ||
| LOGGER.warning("Failed to get mimebundle from chart: %s", e) |
mscolnick
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
We swallowed errors when imports were not installed / configurations were incorrect when rendering altair charts. This can lead to user confusion because their settings were not being respected.
I noticed this when testing #9104 and did not have
vl-convert-pythoninstalled.I'm hoping this isn't too noisy, I've tried several altair notebooks.
📋 Pre-Review Checklist
✅ Merge Checklist