fix: arrow keys lose selection in vim visual mode#9172
Merged
kirangadhave merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
akshayka
approved these changes
Apr 13, 2026
Contributor
akshayka
left a comment
akshayka
left a comment
There was a problem hiding this comment.
Nice video walkthrough in the PR description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9108
Issue reported: In visual mode, arrow keys defaulted to codemirror
cursorLineDownbehavior instead of vimselectLineDown. Same for other arrow keys.Fix:
Replaced default arrow key bindings with visual mode wrappers that defer to vim in visual mode but preserver codemirror behavior in normal/insert mode.
Removed
preventDefault/stopPropogationfrom cell keymap arrow bindings to prevent merged keymap from blocking vim event handlers.Tested the fix in vim mode.
Screen.Recording.2026-04-13.at.2.59.48.PM.mov