Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens access control for proxied endpoints by making the server’s ProxyMiddleware require an authenticated user by default, and adds regression tests to ensure LSP proxy routes reject unauthenticated HTTP and WebSocket traffic.
Changes:
- Add a
require_auth(defaultTrue) flag toProxyMiddlewareand reject unauthenticated HTTP/WebSocket proxy requests. - Update existing proxy middleware tests to supply auth where required and explicitly disable auth for static proxying.
- Add a focused test suite validating LSP proxy auth behavior (HTTP and WebSocket).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
marimo/_server/api/middleware.py |
Adds auth gating to ProxyMiddleware with explicit unauthenticated rejection paths for HTTP and WebSocket. |
tests/_server/api/test_middleware.py |
Updates proxy tests for the new default auth requirement and adds LSP proxy auth coverage. |
akshayka
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.