fix: image dimensions for Altair PNG outputs#9149
Merged
Light2Dark merged 2 commits intomarimo-team:mainfrom Apr 13, 2026
Merged
fix: image dimensions for Altair PNG outputs#9149Light2Dark merged 2 commits intomarimo-team:mainfrom
Light2Dark merged 2 commits intomarimo-team:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bundle ReportBundle size has no change ✅ |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression in the Altair PNG formatter where PNG width/height metadata is emitted as floats, but consumed by the frontend as <img> attributes that require integers.
Changes:
- Cast Altair PNG metadata
width/heighttointwhen constructing the marimo MIME bundle.
9833009 to
71e73c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR fixes a bug introduced in #9049.
Altair returns
widthandheightmetadata as float values for PNG. However, these values are used as thewidthandheightattributes of an<img>element in the frontend. These attributes expect integer values.Changes
widthandheighttointin the Altair formatter's_format_png_mimebundlefunction.📋 Pre-Review Checklist
✅ Merge Checklist