Skip to content

CI: Fix wasm32 build #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovell merged 1 commit into from
Aug 25, 2026
+36 −0
Merged

CI: Fix wasm32 build #4589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,7 @@ jobs:
with:
node-version: "22"
- run: npm install
- run: npx patch-package
- run: npm run build:dist && emmake npm run build
- name: Verify emscripten versions match
run: |
Expand Down
35 changes: 35 additions & 0 deletions patches/emnapi+1.11.3.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
diff --git a/node_modules/emnapi/dist/library_napi.js b/node_modules/emnapi/dist/library_napi.js
index c2ef5b0..210c4c3 100644
--- a/node_modules/emnapi/dist/library_napi.js
+++ b/node_modules/emnapi/dist/library_napi.js
@@ -602,6 +602,12 @@ function _napi_cancel_async_work(env, work) {
var emnapiString = {
utf8Decoder: undefined,
utf16Decoder: undefined,
+ getHeapViewOrCopy: function (heap, start, end) {
+ var buffer = heap.buffer;
+ var isShared = Object.prototype.toString.call(buffer) === '[object SharedArrayBuffer]';
+ var isResizable = buffer.resizable === true;
+ return isShared || isResizable ? heap.slice(start, end) : heap.subarray(start, end);
+ },
init: function () {
#if !TEXTDECODER || TEXTDECODER == 1
var fallbackDecoder = {
@@ -761,7 +767,7 @@ var emnapiString = {
return str;
}
#endif
- return emnapiString.utf8Decoder.decode({{{ getUnsharedTextDecoderView('HEAPU8', 'ptr', 'end') }}});
+ return emnapiString.utf8Decoder.decode(emnapiString.getHeapViewOrCopy(HEAPU8, ptr, end));
},
stringToUTF8: function (str, outPtr, maxBytesToWrite) {
var HEAPU8 = new Uint8Array(wasmMemory.buffer);
@@ -831,7 +837,7 @@ var emnapiString = {
#endif
// eslint-disable-next-line @typescript-eslint/no-unused-vars
var HEAPU8 = new Uint8Array(wasmMemory.buffer);
- return emnapiString.utf16Decoder.decode({{{ getUnsharedTextDecoderView('HEAPU8', 'ptr', 'end') }}});
+ return emnapiString.utf16Decoder.decode(emnapiString.getHeapViewOrCopy(HEAPU8, ptr, end));
},
stringToUTF16: function (str, outPtr, maxBytesToWrite) {
if (maxBytesToWrite === undefined) {