Conversation
louislam
marked this pull request as ready for review
March 24, 2026 18:25
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the setup-database “temp server” so it can serve over HTTPS when Uptime Kuma is configured with SSL key/cert, and updates server URL logging to correctly reflect HTTP vs HTTPS.
Changes:
- Start the setup-database temporary Express server as an HTTPS server when
isSSLis enabled. - Extend
printServerUrls()to support HTTPS URLs and sort network addresses (IPv4 first). - Update the main server startup log to pass SSL state into
printServerUrls().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| server/util-server.js | Enhances printServerUrls() to print HTTPS URLs when applicable, sort addresses, and centralize URL construction. |
| server/setup-database.js | Uses https.createServer() for the setup-database temp server when SSL is configured, and logs HTTPS URLs. |
| server/server.js | Passes SSL state to printServerUrls() for correct startup URL logging. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
louislam
enabled auto-merge (squash)
March 24, 2026 18:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It seems that the temp server for setup-database page is not enabled SSL even if the settings are provided.
Also improved
printServerUrls()for supporting https and sorted by IPv4 firstTODO: the temp server for db migration may have to be fixed too.Too lazy to test, and we can check the progress in the console log, I let it alone first.
Resolves #7086
Please follow this checklist to avoid unnecessary back and forth (click to expand)
I understand that I am responsible for and able to explain every line of code I submit.
Screenshots for Visual Changes