add Faraday#Deprecate to 1.x

[hyuraku]

Description

add Faraday#Deprecate to hide deprecate method's warning message

Fixes #1410

Todos

List any remaining work that needs to be done, i.e:

• Tests
• Documentation

Additional Notes

[iMacTia]

Thank you for bringing this back @hyuraku.
There are some changes that I wouldn't expect in this PR, please see my comment below.
Do you also think you could add some test coverage to check the warnings are correctly output when the skip is disabled?

[iMacTia]

Thank you for addressing all the comments @hyuraku 🙌!
Are you planning to add unit tests as well as I mentioned above?

Do you also think you could add some test coverage to check the warnings are correctly output when the skip is disabled?

[hyuraku]

@iMacTia

check the warnings are correctly output when the skip is disabled?

I want to add the test when the skip is disabled? to spec/faraday/connection_spec.rb.

[iMacTia]

Or better, a generic test around the Faraday::Deprecate#deprecate method 👍!
If we know that works as expected (e.g. with an anonymous class defined in the specs), we don't need to test it everywhere we use it

[iMacTia]

Just realised we can now remove the require from error.rb as well

[iMacTia]

This is not necessary anymore 🙌 !

[hyuraku]

@iMacTia
I added the spec for Faraday::Deprecate#deprecate; could you review this PR?

[iMacTia]

Fantastic work @hyuraku and great test coverage 💯👏
The rubocop offence is unrelated to the PR itself, I'll test this locally and merge if all tests are passing 👍

[iMacTia]

All tests pass locally ✅ 🎉

[kyrofa]

Thank you both!

[kenichi-sonoda]

Sorry, mistake

please delete this message🙏