Conversation
bajtos
approved these changes
Oct 26, 2016
| one singleton instance of model registry. This was very fragile and might not | ||
| ## Changes to loopback-datasource-juggler | ||
|
|
||
| ### loopback-datasource-juggler is now a regular dependency |
Member
There was a problem hiding this comment.
This change was made in loopback, not in loopback-datasource-juggler. I am not sure whether it makes sense to list it under "Changes to loopback-datasource-juggler"?
Also I would add "of loopback" at the end of the title, to prevent confusion.
loopback-datasource-juggler is now a regular dependency of loopback
Contributor
There was a problem hiding this comment.
Yea I discussed this one with @crandmck. Then let's move it under Other changes.
| ``` | ||
|
|
||
| For more information, see [loopback-datasource-juggler#918](https://github.com/strongloop/loopback-datasource-juggler/pull/918). | ||
| ## Changes to to LoopBack models |
Contributor
Author
There was a problem hiding this comment.
Good catch. Fixed.
Contributor
Author
|
Thanks! We can also continue to refine this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to organize the items in the Rel. Notes and Migration Guide to group related things. I also edited it extensively, and add cross-links. I'll probably make at least one more pass to link into the rest of the docs, once I populate the lb3 docs.
@Amir-61 @bajtos