[GG] fix(kv-offload): defer stores until metadata is ready - #153
Conversation
Bound each group store cursor by token eligibility, available hash keys, and complete tracked GPU-block chunks. A lagging metadata source is retried instead of triggering a length assertion or being skipped permanently. Retain the internal key/block length assertion after applying the common readiness bound, and cover queued aborts plus independent key and block-ID lag. Assisted-by: OpenAI Codex Signed-off-by: Derek Yates <derek.yates@live.com>
|
Warning Review limit reached
Next review available in: 15 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Root cause
With async scheduling, token-derived store progress can become visible before either
offload_keysorblock_idsreaches the same chunk boundary. The old code sliced both collections at the token-derived boundary and asserted equal lengths, which could terminateEngineCoreduring queue abort, eviction, or preemption.Removing the assertion or relying on
zip()is not sufficient: advancingnext_stored_chunk_idxpast the missing metadata would silently skip that chunk forever.storable_chunks()now owns the complete invariant and returns only the common ready prefix.Relation to earlier work
This replaces the closed #133, which targeted a transient CUTLASS integration branch instead of
dev/gilded-gnosis.The implementation was re-audited against upstream #49146:
storable_chunks()Validation
Run in the GG release CUDA image:
test_scheduler.py: 97 passedtests/v1/kv_connector/unit/offloading_connector: 142 passedgit diff --checkpassedThe branch is based directly on
dev/gilded-gnosisat73e4a8cde8; there is no stacked base or Docker-only overlay.