Add rule no-done-twice to reject multiple done() calls - #453
Merged
Conversation
lo1tuma
changed the title
lo1tuma
force-pushed
the
add-no-done-twice
branch
2 times, most recently
from
May 25, 2026 02:02
0338d08 to
68aecae
Compare
Report repeated completion of the same Mocha callback in a single control-flow block. Enable the rule in the recommended config and document the expected callback style.
Track callback aliases and one-shot delegation across code paths. Cover renamed callbacks, branch-sensitive completion, and delegated completion cases in rule tests.
Add exact const alias cases for no-done-twice so callback renaming coverage matches the rule behavior.
lo1tuma
force-pushed
the
add-no-done-twice
branch
from
May 25, 2026 08:01
3a63d50 to
4f3cc25
Compare
lo1tuma
added a commit
that referenced
this pull request
Jul 17, 2026
Add rule no-done-twice to reject multiple done() calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new mocha/no-done-twice rule to report repeated completion of the same Mocha callback.
Enable the rule in the recommended config and document the expected callback style.