Add no-code-after-done rule to reject code after done() - #451
Merged
Conversation
lo1tuma
changed the title
lo1tuma
changed the title
no-code-after-done rule to reject code after done()
Report executable statements that run after a Mocha callback has already completed. Cover nested callback bodies and enable the rule in the recommended config.
Track aliased and delegated callback completion across code paths. Cover exact const alias cases and nested callback execution through public rule tests.
lo1tuma
force-pushed
the
add-no-code-after-done
branch
from
May 25, 2026 01:32
0218cc1 to
6376f2b
Compare
lo1tuma
added a commit
that referenced
this pull request
Jul 17, 2026
Add `no-code-after-done` rule to reject code after done()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new mocha/no-code-after-done rule to report executable statements that run after a callback-style test or hook calls done().
Cover nested callback bodies and enable the rule in the recommended config.