Allow commented skips in no-pending-tests - #445
Merged
Conversation
Allow explicit Mocha skip forms when they have an immediate reason comment. Keep bare pending tests disallowed and require the comment to be adjacent to the skipped call without a blank line.
Remove an unreachable guard in the skip comment helper and add a suite skip case for the allowSkippedWithComment option. This restores 100% coverage for the rule under c8.
lo1tuma
added a commit
that referenced
this pull request
Jul 17, 2026
Allow commented skips in no-pending-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #201.
Adds an allowSkippedWithComment option to mocha/no-pending-tests.
It allows explicit skip forms when they have an immediately preceding comment,
while keeping bare pending tests disallowed.