Rename no-top-level-hooks to no-root-hooks - #433
Merged
Conversation
lo1tuma
changed the title
Mocha calls hooks declared outside a suite root hooks. Rename the rule so the public rule id and documentation use Mocha's terminology. BREAKING CHANGE: Users must replace mocha/no-top-level-hooks with mocha/no-root-hooks in ESLint configs.
lo1tuma
force-pushed
the
rename-root-hooks-rule
branch
from
May 23, 2026 09:47
1aa0930 to
1e4af02
Compare
lo1tuma
added a commit
that referenced
this pull request
Jul 17, 2026
Rename no-top-level-hooks to no-root-hooks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mocha calls hooks declared outside a suite root hooks.
This renames
mocha/no-top-level-hookstomocha/no-root-hooksand updates the docs to link to the Mocha Root-Level Hooks documentation.Users should replace
mocha/no-top-level-hookswithmocha/no-root-hooksin their ESLint config.