Skip to content

Fix type of the plugin object's configs field - #393

Merged
lo1tuma merged 3 commits into
lo1tuma:mainfrom
rhysd:issue-392
May 18, 2026
Merged

Fix type of the plugin object's configs field#393
lo1tuma merged 3 commits into
lo1tuma:mainfrom
rhysd:issue-392

Conversation

@rhysd

@rhysd rhysd commented May 31, 2025

Copy link
Copy Markdown
Contributor

Fix #392

By this change plugin.d.ts looks like the following. configs field is no longer optional.

import type { ESLint, Linter } from 'eslint';
export type MochaPlugin = ESLint.Plugin & {
    configs: {
        all: Linter.Config;
        recommended: Linter.Config;
    };
};
declare const mochaPlugin: MochaPlugin;
export default mochaPlugin;
//# sourceMappingURL=plugin.d.ts.map

Comment thread source/plugin.ts Outdated
@mdmower-csnw

Copy link
Copy Markdown
Contributor

@rhysd - Should be able to close this pull request since #400 was accepted.

@lo1tuma lo1tuma added the bug label May 18, 2026
@lo1tuma

lo1tuma commented May 18, 2026

Copy link
Copy Markdown
Owner

Sorry for the late response and thanks for your effort @rhysd.

@lo1tuma
lo1tuma merged commit 702d814 into lo1tuma:main May 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

configs field is wrongly optional in the type definition

3 participants