Skip to content

Revert "Add new board: Purism Librem Mini"#824

Closed
tlaurion wants to merge 1 commit into
masterfrom
revert-806-add_librem_mini
Closed

Revert "Add new board: Purism Librem Mini"#824
tlaurion wants to merge 1 commit into
masterfrom
revert-806-add_librem_mini

Conversation

@tlaurion

@tlaurion tlaurion commented Sep 3, 2020

Copy link
Copy Markdown
Collaborator

@MrChromebox

Copy link
Copy Markdown
Contributor

I don't see the sense in reverting a board addition just because of CI issues -- we certainly wouldn't drop any other existing board for that. Just means that fixing CI needs to be prioritized.

@flammit

flammit commented Sep 3, 2020

Copy link
Copy Markdown
Collaborator

I agree with @MrChromebox. If local builds work, then we should keep the board. It sounds like CI needs to be fixed to match real-world build conditions, which can be on any number of distros that should all build to the same byte-for-byte binary (how it was in the past).

@tlaurion

tlaurion commented Sep 3, 2020

Copy link
Copy Markdown
Collaborator Author

It sounds like CI needs to be fixed to match real-world build conditions, which can be on any number of distros that should all build to the same byte-for-byte binary (how it was in the past).

It is the same. We changed from musl-cross to musl-cross-make which is linked to current kernel reproducibility issue.

@MrChromebox I will close this PR and create another one, removing librem_mini from circleci

As always, your help in fixing gitlabci and circleci is more then welcome. They download specified docker images, then download build required tools and do what they are asked to do the same way it should happen locally. Please review.

@MrChromebox

Copy link
Copy Markdown
Contributor

so is it a docker issue then? I've never used docker in any capacity whatsoever

@tlaurion

tlaurion commented Sep 3, 2020

Copy link
Copy Markdown
Collaborator Author

so is it a docker issue then? I've never used docker in any capacity whatsoever

I will test later on on local docker image downloaded from the same source and test software deployed under CircleCI recipe. But this is not one of my priority for the moment, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants