flash.sh: drop inhouse progress output on console when flashing with flashrom#1755
Merged
tlaurion merged 1 commit intoAug 23, 2024
Merged
Conversation
…flashrom Signed-off-by: Thierry Laurion <insurgo@riseup.net>
This was referenced Aug 23, 2024
Collaborator
Author
|
@JonathonHall-Purism works as intended. Merge? |
Collaborator
|
💯 Let's merge, thank you @tlaurion I'm thrilled to see this go. While it's not awesome to leave users with an indefinite wait, it is far better than sometimes freezing during a critical potentially-bricking operation, and this code was a nightmare to maintain. |
Collaborator
Author
@JonathonHall-Purism please approve! |
JonathonHall-Purism
approved these changes
Aug 23, 2024
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Flashrom dropped --progress output under 1.2.
flashrom 1.4 still has no --progress output.
Heads implemented in-house progress output as a workaround until fixed upstream.
That never happened.
This is still opened issue https://ticket.coreboot.org/issues/390
As per #1753 (comment) @JonathonHall-Purism comment:
So here, we drop progress output and leave user in the dark while they erase/write the firmware internally when upgrading Heads.