util: Move get_entity_name and get_entity_version into util-fabrics. - #3368
Merged
igaw merged 1 commit intoMay 28, 2026
Merged
Conversation
The get_entity_name and get_entity_version utility functions were only used for fabrics. Moves their declarations into private-fabrics.h and their implementations into util-fabrics.c, and adds libnvmf prefix for consistency with other fabrics-only utilities. Signed-off-by: Broc Going <bgoing@micron.com>
Collaborator
|
Sorry for the long delay. I was on two conferences last week and didn't have time to work on upstream. Operations resumed to normal :) Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get_entity_name and get_entity_version utility functions were only used for fabrics. Moves their declarations into private-fabrics.h and their implementations into util-fabrics.c, and adds libnvmf prefix for consistency with other fabrics-only utilities.