This repository was archived by the owner on Feb 1, 2025. It is now read-only.
Fix sub-inheritance mapping attributes generation#347
Merged
Conversation
MaceWindu
approved these changes
Oct 5, 2023
Contributor
|
Thanks! |
MaceWindu
pushed a commit
that referenced
this pull request
Oct 13, 2023
* 1. Fix sub-inheritance mapping attributes generation * 1. Simplification (cherry picked from commit 7d8ffea)
MaceWindu
pushed a commit
that referenced
this pull request
Oct 13, 2023
MaceWindu
pushed a commit
that referenced
this pull request
Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
This PR fixes generation of
InheritanceMappingAttributewhen you have stronger hierarchy than just one child.Example
Let's pretend we have such class hierarchy:
Then when you try to get all
WithInheritanceAobjects linq2db would create this query:But that's wrong: inherited entities
WithInheritanceA1andWithInheritanceA2also should be included in query.My PR fixes that problem by finding all relations between inherited types and then adding it to collection of mapping attributes. Unit test also included, was tested on PgSql