Skip to content

feat(spec): add Icelandic locale support#995

Merged
maxprilutskiy merged 2 commits intomainfrom
devin/1751539843-add-icelandic-locale
Jul 3, 2025
Merged

feat(spec): add Icelandic locale support#995
maxprilutskiy merged 2 commits intomainfrom
devin/1751539843-add-icelandic-locale

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot commented Jul 3, 2025

feat(spec): add Icelandic locale support

Summary

Added support for the Icelandic language by adding the is locale code with the is-IS regional variant to the localeMap in packages/spec/src/locales.ts. This change enables Icelandic language support throughout the lingo.dev internationalization system.

The locale system automatically generates various locale format arrays from the base localeMap object, so adding this entry makes Icelandic available across all lingo.dev packages that depend on locale specifications.

Review & Testing Checklist for Human

  • Verify locale codes are correct: Confirm that is (Icelandic) and is-IS (Iceland) are the correct ISO 639-1 and BCP 47 codes
  • Test end-to-end functionality: Create a test project and verify that Icelandic locale actually works with lingo.dev CLI, compiler, and SDK
  • Review changeset configuration: Check that the changeset is properly configured for a minor version bump and will publish correctly
  • Validate locale placement: Ensure the placement in localeMap follows the intended organizational pattern

Recommended test plan: Create a simple test project with i18n.json configured for Icelandic (is or is-IS) as a target locale, add some translatable content, and run lingo.dev to verify the locale is recognized and translations work properly.


Diagram

%%{ init : { "theme" : "default" }}%%
graph TD
    packages["packages/"]
    spec["packages/spec/"]
    locales["packages/spec/src/locales.ts"]:::major-edit
    changeset[".changeset/soft-seals-doubt.md"]:::major-edit
    
    packages --> spec
    spec --> locales
    
    locales --> localeMap["localeMap object"]
    localeMap --> newEntry["+ is: ['is-IS']"]:::major-edit
    
    locales --> exports["Exported arrays"]
    exports --> localeCodesShort["localeCodesShort"]:::context
    exports --> localeCodesFull["localeCodesFull"]:::context
    exports --> localeCodes["localeCodes"]:::context
    
    subgraph Legend
        L1["Major Edit"]:::major-edit
        L2["Minor Edit"]:::minor-edit  
        L3["Context/No Edit"]:::context
    end

    classDef major-edit fill:#90EE90
    classDef minor-edit fill:#87CEEB
    classDef context fill:#FFFFFF
Loading

Notes

Resolves #994

- Add is (Icelandic) locale code with is-IS regional variant to localeMap
- Create changeset documenting the minor version bump
- Resolves #994

Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@maxprilutskiy maxprilutskiy self-assigned this Jul 3, 2025
@delve-auditor
Copy link
Copy Markdown

delve-auditor Bot commented Jul 3, 2025

No security or compliance issues detected. Reviewed everything up to 6d150d5.

Security Overview
  • 🔎 Scanned files: 2 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► soft-seals-doubt.md
    Add Icelandic locale support
► locales.ts
    Add is-IS locale mapping

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Comment thread .changeset/soft-seals-doubt.md Outdated
@@ -0,0 +1,5 @@
---
"@lingo.dev/_spec": minor
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@lingo.dev/_spec": minor
"@lingo.dev/_spec": patch

@maxprilutskiy
Copy link
Copy Markdown
Contributor

Resolves #994

- Address feedback from @maxprilutskiy
- Adding new locale support is more appropriate as patch-level change

Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>
@maxprilutskiy maxprilutskiy merged commit acd5356 into main Jul 3, 2025
5 checks passed
@maxprilutskiy maxprilutskiy deleted the devin/1751539843-add-icelandic-locale branch July 3, 2025 10:57
mainstar123 pushed a commit to mainstar123/lingo.dev that referenced this pull request Jul 7, 2025
* feat(spec): add Icelandic locale support

- Add is (Icelandic) locale code with is-IS regional variant to localeMap
- Create changeset documenting the minor version bump
- Resolves lingodotdev#994

Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>

* fix(changeset): change version bump from minor to patch

- Address feedback from @maxprilutskiy
- Adding new locale support is more appropriate as patch-level change

Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Max Prilutskiy <maks.prilutskiy@gmail.com>
17prateek12 pushed a commit to 17prateek12/lingo.dev that referenced this pull request Jan 23, 2026
* feat(spec): add Icelandic locale support

- Add is (Icelandic) locale code with is-IS regional variant to localeMap
- Create changeset documenting the minor version bump
- Resolves lingodotdev#994

Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>

* fix(changeset): change version bump from minor to patch

- Address feedback from @maxprilutskiy
- Adding new locale support is more appropriate as patch-level change

Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Max Prilutskiy <maks.prilutskiy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Language request] Please add Icelandic

1 participant