feat(spec): add Icelandic locale support#995
Merged
maxprilutskiy merged 2 commits intomainfrom Jul 3, 2025
Merged
Conversation
- Add is (Icelandic) locale code with is-IS regional variant to localeMap - Create changeset documenting the minor version bump - Resolves #994 Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
✅ No security or compliance issues detected. Reviewed everything up to 6d150d5. Security Overview
Detected Code Changes
Reply to this PR with |
maxprilutskiy
approved these changes
Jul 3, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@lingo.dev/_spec": minor | |||
Contributor
There was a problem hiding this comment.
Suggested change
| "@lingo.dev/_spec": minor | |
| "@lingo.dev/_spec": patch |
Contributor
|
Resolves #994 |
- Address feedback from @maxprilutskiy - Adding new locale support is more appropriate as patch-level change Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>
mainstar123
pushed a commit
to mainstar123/lingo.dev
that referenced
this pull request
Jul 7, 2025
* feat(spec): add Icelandic locale support - Add is (Icelandic) locale code with is-IS regional variant to localeMap - Create changeset documenting the minor version bump - Resolves lingodotdev#994 Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com> * fix(changeset): change version bump from minor to patch - Address feedback from @maxprilutskiy - Adding new locale support is more appropriate as patch-level change Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Max Prilutskiy <maks.prilutskiy@gmail.com>
17prateek12
pushed a commit
to 17prateek12/lingo.dev
that referenced
this pull request
Jan 23, 2026
* feat(spec): add Icelandic locale support - Add is (Icelandic) locale code with is-IS regional variant to localeMap - Create changeset documenting the minor version bump - Resolves lingodotdev#994 Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com> * fix(changeset): change version bump from minor to patch - Address feedback from @maxprilutskiy - Adding new locale support is more appropriate as patch-level change Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Max Prilutskiy <maks.prilutskiy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(spec): add Icelandic locale support
Summary
Added support for the Icelandic language by adding the
islocale code with theis-ISregional variant to thelocaleMapinpackages/spec/src/locales.ts. This change enables Icelandic language support throughout the lingo.dev internationalization system.The locale system automatically generates various locale format arrays from the base
localeMapobject, so adding this entry makes Icelandic available across all lingo.dev packages that depend on locale specifications.Review & Testing Checklist for Human
is(Icelandic) andis-IS(Iceland) are the correct ISO 639-1 and BCP 47 codeslocaleMapfollows the intended organizational patternRecommended test plan: Create a simple test project with
i18n.jsonconfigured for Icelandic (isoris-IS) as a target locale, add some translatable content, and runlingo.devto verify the locale is recognized and translations work properly.Diagram
%%{ init : { "theme" : "default" }}%% graph TD packages["packages/"] spec["packages/spec/"] locales["packages/spec/src/locales.ts"]:::major-edit changeset[".changeset/soft-seals-doubt.md"]:::major-edit packages --> spec spec --> locales locales --> localeMap["localeMap object"] localeMap --> newEntry["+ is: ['is-IS']"]:::major-edit locales --> exports["Exported arrays"] exports --> localeCodesShort["localeCodesShort"]:::context exports --> localeCodesFull["localeCodesFull"]:::context exports --> localeCodes["localeCodes"]:::context subgraph Legend L1["Major Edit"]:::major-edit L2["Minor Edit"]:::minor-edit L3["Context/No Edit"]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
Resolves #994