feat: add support for locked patterns in mdx loader by devin-ai-integration[bot] · Pull Request #700 · lingodotdev/lingo.dev

devin-ai-integration · 2025-05-02T18:19:20Z

Add support for locked patterns in MDX loader

This PR adds support for preserving specific patterns in MDX files during translation, focusing on the syntax used in documentation like the Solana examples.

Implementation Details

Added a new loader specifically for locked patterns that preserves regex-matched content during translation
Implemented a new config version 1.7 with a "lockedPatterns" field that accepts an array of regex patterns
Added support for patterns like:
- !params syntax
- !! parameter_name headings
- !type string declarations
- !required flags
- !values lists

Configuration

The implementation adds a new field to the bucket configuration in i18n.json:

"lockedPatterns": [
  "!params",
  "!! [\\w_]+",
  "!type [\\w<>\\[\\]\"',]+",
  "!required",
  "!values [\\s\\S]*?(?=\\n\\n|$)"
]

Testing

Added comprehensive unit tests for the locked patterns loader
Tests verify that patterns are correctly preserved during translation
Included real-world examples from Solana documentation
All tests are passing

Link to Devin run: https://app.devin.ai/sessions/e0df584394174a33ae57acca13dddba7
Requestor: Max Prilutskiy (max@lingo.dev)

Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>

devin-ai-integration · 2025-05-02T18:19:27Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

…ontain Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>

Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>

maxprilutskiy · 2025-05-02T19:07:40Z

+    async pull(locale, input, initCtx, originalLocale) {
+      const patterns = defaultPatterns || [];
+
+      const { content, lockedPlaceholders } = extractLockedPatterns(input || "", patterns);
+
+      return {
+        content,
+        lockedPlaceholders,
+      };
+    },
+
+    async push(locale, data) {
+      let result = data.content;
+      for (const [placeholder, original] of Object.entries(data.lockedPlaceholders)) {
+        result = result.replaceAll(placeholder, original);
+      }
+
+      return result;
+    },
+  });


should return string, not obkect

in push, use pullInput +extractLockedPatterns again to recreate the lockedPlaceholders map

…Input Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>

maxprilutskiy · 2025-05-02T19:14:35Z

+    async push(locale, data) {
+      const patterns = defaultPatterns || [];
+
+      const pullInput = (global as any).__pullInput || null;
+
+      if (!pullInput) {
+        return data;
+      }
+
+      const { lockedPlaceholders } = extractLockedPatterns(pullInput, patterns);
+
+      let result = data;
+      for (const [placeholder, original] of Object.entries(lockedPlaceholders)) {
+        result = result.replaceAll(placeholder, original);
+      }
+
+      return result;
+    },
+  });


refer to the definition of createLoader to understand how to use pull input

…ameter Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>

* feat: add support for locked patterns in mdx loader Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com> * test: update locked patterns tests to use toBe instead of toMatch/toContain Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com> * fix(mdx): fix locked patterns tests and improve regex patterns Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com> * fix: make locked patterns configurable via i18n.json Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com> * refactor: remove default patterns fallback in locked patterns loader Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com> * refactor: update locked patterns loader to return string and use pullInput Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com> * refactor: update locked patterns loader to properly use pullInput parameter Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Max Prilutskiy <maks.prilutskiy@gmail.com> Co-authored-by: Max Prilutskiy <5614659+maxprilutskiy@users.noreply.github.com>

feat: add support for locked patterns in mdx loader

ac6f3c1

Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>

devin-ai-integration Bot and others added 2 commits May 2, 2025 18:22

test: update locked patterns tests to use toBe instead of toMatch/toC…

6c7d59a

…ontain Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>

fix(mdx): fix locked patterns tests and improve regex patterns

1d725a3

Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>

maxprilutskiy reviewed May 2, 2025

View reviewed changes

Comment thread packages/cli/src/cli/loaders/mdx2/locked-patterns.ts Outdated

devin-ai-integration Bot and others added 2 commits May 2, 2025 18:59

fix: make locked patterns configurable via i18n.json

e4255f9

Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>

refactor: remove default patterns fallback in locked patterns loader

bd4443b

Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>

maxprilutskiy reviewed May 2, 2025

View reviewed changes

refactor: update locked patterns loader to return string and use pull…

2df97ee

…Input Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>

maxprilutskiy reviewed May 2, 2025

View reviewed changes

devin-ai-integration Bot and others added 2 commits May 2, 2025 19:17

refactor: update locked patterns loader to properly use pullInput par…

365e64b

…ameter Co-Authored-By: Max Prilutskiy <maks.prilutskiy@gmail.com>

Merge branch 'main' into devin/1746209518-mdx-locked-patterns

a2ed791

maxprilutskiy merged commit c5ccf81 into main May 2, 2025
2 checks passed

maxprilutskiy deleted the devin/1746209518-mdx-locked-patterns branch May 2, 2025 19:20

github-actions Bot mentioned this pull request May 2, 2025

chore: bump package versions #707

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for locked patterns in mdx loader#700

feat: add support for locked patterns in mdx loader#700
maxprilutskiy merged 8 commits intomainfrom
devin/1746209518-mdx-locked-patterns

devin-ai-integration Bot commented May 2, 2025

Uh oh!

devin-ai-integration Bot commented May 2, 2025

Uh oh!

Uh oh!

maxprilutskiy May 2, 2025

Uh oh!

maxprilutskiy May 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

devin-ai-integration Bot commented May 2, 2025

Add support for locked patterns in MDX loader

Implementation Details

Configuration

Testing

Uh oh!

devin-ai-integration Bot commented May 2, 2025

🤖 Devin AI Engineer

Uh oh!

Uh oh!

maxprilutskiy May 2, 2025

Choose a reason for hiding this comment

Uh oh!

maxprilutskiy May 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant